fix: correct styling issues indicated by clang-format and ruff and refactor scripts/icclrun.py#25
Merged
Merged
Conversation
halfman510
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses code formatting and style compliance across the codebase as flagged by
clang-formatandruff. Crucially, to satisfyruff's module-level import placement rules without breaking runtime dependency resolution,scripts/icclrun.pyhas been refactored to cleanly separate bootstrapping operations from global execution scopes.Changes
scripts/icclrun.pyRefactorsys.pathenvironment scanning and library locating logic into a dedicated lifecycle functionconfigure_system_paths();from icclrun_logic import ICCLLauncherstatement inside themain()entry point, successfully satisfying PEP 8 / Ruff import ordering constraints (E402) while preserving the application's runtime path initialization sequence.Style Fix
clang-formatfor C++ components andrufffor Python files.Known Issues & Future Work
icclrun_logicmodule standardly or utilizing entry-point hooks to decouple runtime paths completely from raw script execution paths.Logs & Screenshots
Tested on a NVIDIA + MetaX heterogeneous cluster
all_gather.log
all_reduce.log
all_to_all.log
broadcast.log
reduce_scatter.log
send_recv.log