Skip to content

fix: correct styling issues indicated by clang-format and ruff and refactor scripts/icclrun.py#25

Merged
Ziminli merged 2 commits into
masterfrom
fix/fix-style-issues
May 26, 2026
Merged

fix: correct styling issues indicated by clang-format and ruff and refactor scripts/icclrun.py#25
Ziminli merged 2 commits into
masterfrom
fix/fix-style-issues

Conversation

@Ziminli
Copy link
Copy Markdown
Collaborator

@Ziminli Ziminli commented May 26, 2026

Summary

This PR addresses code formatting and style compliance across the codebase as flagged by clang-format and ruff. Crucially, to satisfy ruff's module-level import placement rules without breaking runtime dependency resolution, scripts/icclrun.py has been refactored to cleanly separate bootstrapping operations from global execution scopes.

Changes

  • scripts/icclrun.py Refactor

    • extract the dynamic sys.path environment scanning and library locating logic into a dedicated lifecycle function configure_system_paths();
    • localize the from icclrun_logic import ICCLLauncher statement inside the main() entry point, successfully satisfying PEP 8 / Ruff import ordering constraints (E402) while preserving the application's runtime path initialization sequence.
  • Style Fix

    • rectify all formatting, whitespace, and linting non-compliances across the changed workspace files using clang-format for C++ components and ruff for Python files.

Known Issues & Future Work

  • While localizing dependencies inside functions clears module-level validation constraints, widespread use of dynamic path injection can occasionally confuse static type checkers or IDE auto-completion engines. Future work may explore packaging the internal icclrun_logic module standardly or utilizing entry-point hooks to decouple runtime paths completely from raw script execution paths.

Logs & Screenshots

Tested on a NVIDIA + MetaX heterogeneous cluster
all_gather.log
all_reduce.log
all_to_all.log
broadcast.log
reduce_scatter.log
send_recv.log

@Ziminli Ziminli self-assigned this May 26, 2026
@Ziminli Ziminli requested a review from halfman510 May 26, 2026 11:12
@Ziminli Ziminli merged commit 10b8448 into master May 26, 2026
2 checks passed
@Ziminli Ziminli deleted the fix/fix-style-issues branch May 26, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants