Skip to content

feat(pam): redis account type - #338

Open
x032205 wants to merge 6 commits into
mainfrom
PAM-358
Open

feat(pam): redis account type#338
x032205 wants to merge 6 commits into
mainfrom
PAM-358

Conversation

@x032205

@x032205 x032205 commented Jul 28, 2026

Copy link
Copy Markdown
Member

Description 📣

Redis account type

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@x032205
x032205 requested a review from saifsmailbox98 July 28, 2026 12:05
@linear

linear Bot commented Jul 28, 2026

Copy link
Copy Markdown

PAM-358

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-338-feat-pam-redis-account-type

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

Comment thread packages/gateway-v2/test_connection_handler.go Outdated
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds Redis PAM account support and broadens gateway connection testing.

  • Routes account-based Redis PAM sessions through the local Redis proxy.
  • Adds Redis, SQL, MongoDB, LDAP, and Kubernetes connection-test implementations.
  • Adds database and directory drivers and refreshes related Go dependencies.

Confidence Score: 3/5

The Redis connection-test authentication path should be fixed before merging because valid password-only Redis targets are currently rejected.

The new Redis test only sends AUTH when both username and password are populated, so requirepass/default-user deployments reach PING unauthenticated and return NOAUTH despite valid credentials.

Files Needing Attention: packages/gateway-v2/test_connection_handler.go

Important Files Changed

Filename Overview
packages/gateway-v2/test_connection_handler.go Adds several protocol-specific connection tests, but Redis password-only targets are not authenticated before PING.
packages/pam/local/access.go Enables account-path Redis sessions using the existing local proxy and gateway capability flow.
go.mod Adds the drivers required by the expanded connection-test implementations and updates supporting Go modules.
e2e/go.mod Synchronizes e2e dependency versions and transitive modules with the root module.

Reviews (1): Last reviewed commit: "feat(pam): redis account type" | Re-trigger Greptile

Comment thread packages/pam/local/access.go
@veria-ai

veria-ai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

PR overview

All previously flagged issues have been addressed. No open security concerns remain on this pull request.

Security review

No open security issues remain on this pull request.

Fixed/addressed: 3 · PR risk: 0/10

Comment thread packages/pam/local/access.go
Comment thread packages/pam/handlers/redis/proxy.go
Comment thread packages/gateway-v2/test_connection_handler.go
Comment thread packages/pam/local/access.go
Comment thread packages/pam/local/access.go
Comment thread packages/gateway-v2/test_connection_handler.go
Comment thread packages/gateway-v2/test_connection_handler.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants