Skip to content

fix(pam): e2e tests - #346

Open
x032205 wants to merge 2 commits into
mainfrom
PAM-336
Open

fix(pam): e2e tests#346
x032205 wants to merge 2 commits into
mainfrom
PAM-336

Conversation

@x032205

@x032205 x032205 commented Aug 1, 2026

Copy link
Copy Markdown
Member

Description 📣

Fix pam e2e tests

Type ✨

@linear

linear Bot commented Aug 1, 2026

Copy link
Copy Markdown

PAM-336

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-346-fix-pam-e2e-tests

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@gitguardian

gitguardian Bot commented Aug 1, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
30250094 Triggered Generic Password ab33130 e2e/pam/redis_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@greptile-apps

greptile-apps Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR migrates PAM E2E tests to the folder, account-template, and account APIs while regenerating the scoped OpenAPI client.

  • Adds shared PAM folder and account-template creation helpers.
  • Updates PostgreSQL, SSH, RDP, and Redis scenarios for the new account model.
  • Reworks SSH session verification and account-specific certificate setup.
  • Updates generated client models and operations for the current backend schema.

Confidence Score: 4/5

The certificate-auth ordering defect should be fixed before merging because it can make the newly enabled SSH E2E suite time out during account creation.

Certificate account creation performs its gateway connection validation before the SSH target is configured to trust the account-specific CA, leaving the setup step unreachable when creation fails.

Files Needing Attention: e2e/pam/ssh_test.go

Important Files Changed

Filename Overview
e2e/pam/ssh_test.go Migrates SSH tests to account-based PAM flows, but certificate setup occurs after account creation's connection validation and can prevent that subtest from creating its account.
e2e/pam/pam_helpers.go Adds shared folder and account-template helpers and returns their generated IDs for protocol tests.
e2e/pam/postgres_test.go Migrates PostgreSQL setup from resource-based creation to a folder/template/account request.
e2e/pam/redis_test.go Implements new-model Redis scenarios, but the suite remains explicitly skipped until backend Redis PAM support lands.
e2e/pam/rdp_test.go Migrates the skipped RDP scenarios to Windows PAM account creation.
e2e/openapi-cfg.yaml Replaces obsolete PAM resource operations with folder and account-template generation.
e2e/packages/client/client.gen.go Regenerates API operations and request/response types for the backend's updated PAM and certificate APIs.

Reviews (1): Last reviewed commit: "restore PAM e2e tests" | Re-trigger Greptile

Comment thread e2e/pam/ssh_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant