Conversation
|
💬 Discussion in Slack: #pr-review-cli-346-fix-pam-e2e-tests Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 30250094 | Triggered | Generic Password | ab33130 | e2e/pam/redis_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
| Filename | Overview |
|---|---|
| e2e/pam/ssh_test.go | Migrates SSH tests to account-based PAM flows, but certificate setup occurs after account creation's connection validation and can prevent that subtest from creating its account. |
| e2e/pam/pam_helpers.go | Adds shared folder and account-template helpers and returns their generated IDs for protocol tests. |
| e2e/pam/postgres_test.go | Migrates PostgreSQL setup from resource-based creation to a folder/template/account request. |
| e2e/pam/redis_test.go | Implements new-model Redis scenarios, but the suite remains explicitly skipped until backend Redis PAM support lands. |
| e2e/pam/rdp_test.go | Migrates the skipped RDP scenarios to Windows PAM account creation. |
| e2e/openapi-cfg.yaml | Replaces obsolete PAM resource operations with folder and account-template generation. |
| e2e/packages/client/client.gen.go | Regenerates API operations and request/response types for the backend's updated PAM and certificate APIs. |
Reviews (1): Last reviewed commit: "restore PAM e2e tests" | Re-trigger Greptile
Description 📣
Fix pam e2e tests
Type ✨
Bug fix
New feature
Improvement
Breaking change
Documentation
I have read the contributing guide, agreed and acknowledged the code of conduct. 📝