Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Android-side 2FA approval support using Infomaniak Core and Firebase Cloud Messaging.
Changes:
- Adds 2FA approval UI and dependency injection.
- Registers devices and handles 2FA push notifications.
- Configures Firebase, notification channels, and dependencies.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
NotificationsUtils.kt |
Adds the 2FA notification channel. |
MainApplication.kt |
Starts notification registration and cleanup integration. |
MainActivity.kt |
Displays the 2FA approval sheet. |
SwissTransferFirebaseMessagingService.kt |
Handles FCM tokens and 2FA messages. |
RegisterUserDeviceWorker.kt |
Registers enabled notification topics. |
ApplicationModule.kt |
Provides the 2FA manager. |
AndroidManifest.xml |
Registers the Firebase messaging service. |
google-services.json |
Adds Firebase project configuration. |
app/build.gradle.kts |
Adds Google Services, Firebase, and 2FA dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "client_info": { | ||
| "mobilesdk_app_id": "1:890863238862:android:d6eadefaa2c25f7ffc5a9f", | ||
| "android_client_info": { | ||
| "package_name": "com.infomaniak.swisstransfer" |
| configureSentry() | ||
|
|
||
| userDataCleanableList = listOf<AssociatedUserDataCleanable>(DeviceInfoUpdateManager) | ||
| userDataCleanableList = listOf(DeviceInfoUpdateManager, NotificationsRegistrationManager) |
| implementation(core.splitties.toast) | ||
| implementation(core.splitties.preferences) | ||
| implementation(core.okhttp) | ||
| implementation(core.firebase.messaging.ktx) |
| val appSettings by myAccountViewModel.appSettingsFlow.collectAsStateWithLifecycle(initialValue = null) | ||
| val isInDarkTheme = isDarkTheme(getTheme = { appSettings?.theme }) | ||
|
|
||
| TwoFactorAuthApprovalAutoManagedBottomSheet(twoFactorAuthManager, isInDarkTheme = isInDarkTheme) |
LouisCAD
disabled auto-merge
August 13, 2026 15:30
LouisCAD
marked this pull request as draft
August 13, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for two factor authentication.