feat: Do not display the review pop-up again if the user clicks no

[Elouan1411]

No description provided.

[Copilot]

Pull request overview

Adds a persistent “do not show again” flag to the in-app review gating logic so that once a user declines (via the negative/feedback path), the review prompt won’t be shown in future sessions.

Changes:

• Introduce a new DataStore preference key (DO_NOT_SHOW_AGAIN_KEY) with a default value.
• Update shouldDisplayReviewDialog to also depend on the new “do not show again” flag.
• Persist the “do not show again” flag when the user chooses the feedback/negative action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
InAppReview/src/standard/kotlin/com/infomaniak/core/inappreview/reviewmanagers/InAppReviewManager.kt	Includes the new flag in the dialog display conditions and writes the flag when the user selects the negative/feedback path.
InAppReview/src/main/kotlin/com/infomaniak/core/inappreview/AppReviewSettingsRepository.kt	Adds the new DataStore key and default initial value wiring.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 8ec8440)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Race Condition In onUserWantsToGiveFeedback, both resetAppReviewSettings() and disableReviewDialog() launch separate coroutines on Dispatchers.IO without synchronization. If resetAppReviewSettings() executes after disableReviewDialog(), it may overwrite the DO_NOT_SHOW_AGAIN_KEY value back to false, causing the review dialog to appear again despite the user having already chosen to give feedback. These operations should be combined into a single atomic transaction or properly sequenced to ensure the "do not show again" flag persists. override fun onUserWantsToGiveFeedback(feedbackUrl: String) { onUserWantsToGiveFeedback?.invoke() resetAppReviewSettings() WebViewActivity.startActivity(activity, feedbackUrl) disableReviewDialog()

[github-actions]

Persistent review updated to latest commit 5225da1

[github-actions]

Failed to generate code suggestions for PR

[github-actions]

Persistent review updated to latest commit 8ec8440

[github-actions]

Failed to generate code suggestions for PR

[github-actions]

Failed to generate code suggestions for PR

[FabianDevel]

You shouldn't add a new preference.
The logic now is that either way if you click on one or the other button, the popup should not come back.
So you can use a single preference for both

The best should be that you don't do anything by default, and just move the logic of the threshold on the onDismiss action

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (4)

InAppReview/src/main/kotlin/com/infomaniak/core/inappreview/BaseInAppReviewManager.kt:31

• Removing this parameter changes the public init method descriptor, so existing consumers can fail to compile (named argument) or at runtime (NoSuchMethodError) even when they did not explicitly set it. Preserve a deprecated compatibility overload/parameter while transitioning consumers; the implementation may ignore it under the new one-shot behavior.

    open fun init(
        countdownBehavior: Behavior = Behavior.LifecycleBased,
        appReviewThreshold: Int? = null,
        onUserWantToReview: (() -> Unit)? = null,
        onUserWantToGiveFeedback: (() -> Unit)? = null

InAppReview/src/standard/kotlin/com/infomaniak/core/inappreview/reviewmanagers/InAppReviewManager.kt:89

• setAppReviewedStatus now records that the dialog was shown, not that the app was reviewed. Rename it to match the persisted state and avoid callers treating this as proof that a review occurred.

    override fun onReviewDialogShown() {
        setAppReviewedStatus()

InAppReview/README.md:79

• This example marks the prompt as asked while rendering under if (shouldDisplay). The DataStore update then makes the flow emit false, recomposes this branch away, and dismisses the dialog before the user can choose an action. Keep dialog visibility in separate remembered state and perform the persistence call as a side effect.

    if (shouldDisplay) {
        reviewManager.onReviewDialogShown()
        ReviewDialog(

InAppReview/src/standard/kotlin/com/infomaniak/core/inappreview/reviewmanagers/InAppReviewManager.kt:47

• These names still mix the old “gave review” meaning with the new “was asked” state, and alreadyAskReview is not a clear boolean name. Rename the flow and lambda parameter consistently so future changes do not mistake displaying the prompt for submitting a review.

This issue also appears on line 88 of the same file.

    override val shouldDisplayReviewDialog =
        combine(alreadyAskReview, appReviewCountdown) { alreadyGaveReview, countdown ->
            !alreadyGaveReview && countdown <= 0