feat: Add ContactCard state, primitives and small components - #820
Open
Elouan1411 wants to merge 10 commits into
Open
feat: Add ContactCard state, primitives and small components#820Elouan1411 wants to merge 10 commits into
Elouan1411 wants to merge 10 commits into
Conversation
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
July 24, 2026 06:59
2af33ef to
74b2c73
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
July 24, 2026 07:23
74b2c73 to
4772e69
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
July 24, 2026 07:28
4772e69 to
d1fb95a
Compare
Elouan1411
changed the title
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
3 times, most recently
from
July 24, 2026 08:09
71026ed to
fdb1a22
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds reusable state, styling defaults, and Compose primitives for the Contact Card feature.
Changes:
- Adds top-bar state and customizable colors.
- Adds editor, preview, loading, dialog, and layout components.
- Adds preview fixtures for contact-card UI tooling.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
ContactCardTopBarState.kt |
Defines top-bar modes and callbacks. |
ContactCardDefaults.kt |
Provides theme-aware card colors. |
SectionCard.kt |
Adds section container UI. |
PreviewTopBar.kt |
Adds preview navigation actions. |
PreviewData.kt |
Provides preview model fixtures. |
LoadingContent.kt |
Adds centered loading UI. |
FieldDivider.kt |
Adds field separator styling. |
EditorTopBar.kt |
Adds editor cancel/save actions. |
EditorField.kt |
Adds reusable single-line input. |
DefaultValidationErrorDialog.kt |
Adds validation error dialog. |
DefaultDeleteConfirmationDialog.kt |
Adds deletion confirmation dialog. |
ContactInfoRows.kt |
Displays available contact information. |
ContactCardTopBar.kt |
Adds shared centered top bar. |
ContactCardConstants.kt |
Defines shared card radius. |
BottomSheetAction.kt |
Adds reusable bottom-sheet action row. |
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
August 3, 2026 15:05
fdb1a22 to
a3fce2a
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
August 11, 2026 10:39
a3fce2a to
e082a8f
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
August 12, 2026 12:32
e082a8f to
9a91d1e
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
August 13, 2026 06:54
9a91d1e to
3480a38
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
August 13, 2026 06:57
3480a38 to
e314d75
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
August 13, 2026 07:26
e314d75 to
e16e4c4
Compare
tevincent
requested changes
Aug 13, 2026
| } | ||
| } | ||
| Column(modifier = modifier) { | ||
| rows.forEachIndexed { index, (label, value) -> |
Contributor
There was a problem hiding this comment.
if you don't have anything in rows, no need to have an empty column ?
Contributor
Author
There was a problem hiding this comment.
There will always be at least one Row since phone is required
| import com.infomaniak.core.ui.compose.contactcard.R | ||
|
|
||
| @Composable | ||
| internal fun DefaultValidationErrorDialog( |
Contributor
There was a problem hiding this comment.
You could group DefaultDeleteConfirmationDialog and DefaultValidationErrorDialog. the only thing changing are the strings.
| internal fun LoadingContent() { | ||
| Box(modifier = Modifier.fillMaxSize(), contentAlignment = Alignment.Center) { | ||
| CircularProgressIndicator() | ||
| } |
Contributor
There was a problem hiding this comment.
Was that really necessary instead of just using the CircularProgressIndicator where you needed it ?
| import com.infomaniak.core.auth.models.user.preferences.OrganizationPreference | ||
| import com.infomaniak.core.auth.models.user.preferences.Preferences | ||
|
|
||
| internal fun previewUser(): User { |
Contributor
There was a problem hiding this comment.
You could use PreviewParameterProvider for that.
| ) | ||
| } | ||
| }, | ||
| ) |
Contributor
There was a problem hiding this comment.
That's not really necessary to create a Composable just for the preview. Especially here, it's not that long.
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
August 13, 2026 16:09
e16e4c4 to
e314d75
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.