feat: Add ContactCard screen, editor, preview and onboarding - #822
Open
Elouan1411 wants to merge 12 commits into
Open
feat: Add ContactCard screen, editor, preview and onboarding#822Elouan1411 wants to merge 12 commits into
Elouan1411 wants to merge 12 commits into
Conversation
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
from
July 24, 2026 06:59
adb2a70 to
a3f07ae
Compare
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
from
July 24, 2026 07:23
a3f07ae to
e74afd2
Compare
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
2 times, most recently
from
July 24, 2026 08:09
a4e584a to
57ceebf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the Contact Card Compose flow for onboarding, editing, previewing, sharing, and deletion.
Changes:
- Introduces state-driven Contact Card screen navigation.
- Adds onboarding and editor interfaces.
- Adds preview content and edit/delete actions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
ContactCardScreen.kt |
Coordinates screen states, actions, dialogs, and top bars. |
PreviewContent.kt |
Displays the contact card and share action. |
PreviewActionsBottomSheet.kt |
Provides edit and delete actions. |
OnboardingContent.kt |
Adds onboarding content and creation action. |
EditorContent.kt |
Adds contact fields, URL management, and validation. |
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
2 times, most recently
from
August 3, 2026 15:05
c8077ad to
04299b9
Compare
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
from
August 11, 2026 10:38
04299b9 to
5cbc2f8
Compare
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
3 times, most recently
from
August 12, 2026 11:38
6a5dad7 to
8880bbd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
from
August 12, 2026 12:32
8880bbd to
e8d51cf
Compare
FabianDevel
requested changes
Aug 12, 2026
| val lastname: String, | ||
| val email: String, | ||
| val avatar: String?, | ||
| @SerializedName("phones") @SerialName("phones") |
Contributor
There was a problem hiding this comment.
This is useless if it's the same name as the variable
FabianDevel
approved these changes
Aug 12, 2026
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
from
August 13, 2026 06:54
4ffc257 to
76d5b01
Compare
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
from
August 13, 2026 06:57
76d5b01 to
95d9334
Compare
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
from
August 13, 2026 07:26
95d9334 to
dd06c0e
Compare
tevincent
requested changes
Aug 13, 2026
| onRemoveAdditionalUrl: (String) -> Unit, | ||
| onUpdateDraft: (ContactCardEditorState) -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| confirmValidationError: ((onConfirmed: () -> Unit) -> Unit)? = null, |
Contributor
There was a problem hiding this comment.
It seems you never use onConfirmed: () -> Unit.
| modifier = modifier | ||
| .verticalScroll(rememberScrollState()) | ||
| .padding(vertical = Margin.Medium), | ||
| verticalArrangement = androidx.compose.foundation.layout.Arrangement.spacedBy(Margin.Medium), |
Contributor
There was a problem hiding this comment.
You can add an import for this.
|
|
||
| @Composable | ||
| internal fun OnboardingContent( | ||
| userName: String, |
|
|
||
| @Composable | ||
| @OptIn(ExperimentalMaterial3Api::class) | ||
| internal fun PreviewActionsBottomSheet( |
Contributor
There was a problem hiding this comment.
The navigation bar buttons background is not transparent.
| matomoInstance?.trackScreen(path = screenName, title = screenName) | ||
| } | ||
|
|
||
| const val CONTACT_CARD_CATEGORY = "contactCard" |
Contributor
There was a problem hiding this comment.
You have to put that at the top and in private since it's only used here.
| //region Previews | ||
|
|
||
| @Composable | ||
| private fun DefaultTopBar(state: ContactCardTopBarState) { |
Contributor
There was a problem hiding this comment.
I think you can put this in its own file.
|
|
||
| HttpClient.okHttpClient.newCall(request).await().use { response -> | ||
| val body = response.body ?: return@runCatching null to null | ||
| val body = response.body |
Contributor
There was a problem hiding this comment.
I just noticed that you load this from ContactCardFragmentwhich is not great. It should be done from the viewModel.
Elouan1411
force-pushed
the
vcard-5-screen-content
branch
from
August 13, 2026 16:09
dd06c0e to
95d9334
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.