Conversation
|
tevincent
marked this pull request as draft
August 14, 2026 08:54
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the Android build to AGP 9.1.1, Gradle 9.3.1, and compile SDK 37.
Changes:
- Updates build tooling and AGP compatibility settings.
- Adapts convention and lint plugins to AGP 9 APIs.
- Adds missing module dependencies and conditional ProGuard configuration.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
AGENTS.md |
Documents compile SDK 37. |
BugTracker/build.gradle.kts |
Adds Material Components. |
Coil/build.gradle.kts |
Adds the Compose BOM. |
build-logic/composeLint/src/main/kotlin/com/infomaniak/core/compose/lint/ComposeLintPlugin.kt |
Updates AGP extension configuration. |
build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt |
Handles optional ProGuard files. |
build-logic/convention/src/main/kotlin/AndroidModuleConfig.kt |
Adopts AGP 9 DSL types and SDK 37. |
gradle.properties |
Enables temporary legacy DSL and Kotlin integration. |
gradle/core.versions.toml |
Updates AGP and Hilt. |
gradle/wrapper/gradle-wrapper.properties |
Selects Gradle 9.3.1. |
gradlew |
Updates the POSIX wrapper launcher. |
gradlew.bat |
Updates the Windows wrapper launcher. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| @rem Execute Gradle | ||
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %* | ||
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* |
| "-Dorg.gradle.appname=$APP_BASE_NAME" \ | ||
| -classpath "$CLASSPATH" \ | ||
| org.gradle.wrapper.GradleWrapperMain \ | ||
| -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.