feat: Reply with euria by solrubado · Pull Request #2986 · Infomaniak/android-kMail

solrubado · 2026-07-17T12:08:25Z

No description provided.

Copilot

Pull request overview

Adds an Euria-assisted reply flow from message threads, reusing the existing AI prompt and proposition UI.

Changes:

Adds an AI Reply action and prompt bottom sheet.
Reuses AI proposition generation with message context arguments.
Extracts the AI prompt into a reusable custom view.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`new_message_navigation.xml`	Adds the optional message UID argument.
`main_navigation.xml`	Registers the reply prompt and proposition destinations.
`view_ai_prompt.xml`	Hosts the reusable prompt view.
`view_ai_prompt_content.xml`	Updates the prompt layout header.
`bottom_sheet_ask_euria_actions.xml`	Adds the Reply action.
`ic_reply_euria.xml`	Adds the Euria reply icon.
`AiPromptView.kt`	Encapsulates prompt UI behavior.
`AiPropositionFragment.kt`	Supports generation from a thread message.
`AiPromptFragment.kt`	Adopts the reusable prompt view.
`ThreadFragment.kt`	Coordinates the new reply navigation flow.
`EuriaPromptBottomSheet.kt`	Implements the thread reply prompt.
`AskEuriaBottomSheetDialog.kt`	Handles Reply action selection.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

app/src/main/java/com/infomaniak/mail/ui/newMessage/AiPropositionFragment.kt:325

This conversion treats every body as HTML. For text/plain messages, htmlToText() removes newline characters before parsing, which concatenates lines; for HTML replies it also retains quoted history instead of using the existing quote-aware conversion in NewMessageViewModel. Reuse a shared Body.asPlainText() implementation so Euria receives the same clean context as the composer flow.

                aiViewModel.previousMessageBodyPlainText = message?.body?.value?.htmlToText()

app/src/main/java/com/infomaniak/mail/ui/newMessage/AiPropositionFragment.kt:152

Reading currentMailbox.value only once can leave mailbox uninitialized when this destination is restored before the asynchronous LiveData query emits. Generation then accesses mailbox.uuid and crashes. Await a non-null mailbox (or initialize and generate in one coroutine) instead of returning permanently on the initial null value.

                mainViewModel.currentMailbox.value ?: return@launch

…osition

FabianDevel · 2026-08-11T06:25:04Z

+) : FrameLayout(context, attrs, defStyleAttr) {
+
+    private val binding = ViewAiPromptContentBinding.inflate(LayoutInflater.from(context), this, true)
+    private var onPromptChanged: ((String) -> Unit)? = null


You can remove this variable and directly use the one you pass as argument in the doAfterTextChanged.

Also as bind could theoretically be called several time you would stack listeners to the button because they aren't cleared before adding.
(But this would be a dev error, so i'm not for complexifying the code to avoid a simple dev error)

FabianDevel · 2026-08-11T08:03:24Z

+        }
+
+        if (binding.reply.trailingContent != TrailingContent.None) {
+            binding.reply.setOnClickListener {


I think opening the kSuite bottomsheet should dismiss this one.
Like the mail or threadActionBottomsheet

FabianDevel · 2026-08-11T12:50:10Z

    private val navigationArgs: AiPropositionFragmentArgs by navArgs()

    private var currentRequestJob: Job? = null
+    lateinit var mailbox: Mailbox


Never use lateinit, it's "old code" and it's crash prone.
Use a nullable variable if it's absolutely necessary

But here you can just use a by lazy (in a lot of cases lateinit can be replace by by lazy)

I'm still pretty annoyed by the fact that we use this fragment in both activities instead of opening this from the newMessageActivity directly :/

And this force us to do this kind of manipulation with mailbox from one or the other viewModel

…o ai proposition

…fore starting generation

…or MainActivity

…my request" button

…y values

…ve line breaks

…tion

FabianDevel · 2026-08-12T07:38:13Z

+        val mailbox = mainViewModel.currentMailbox.value
+        val kSuite = mailbox?.kSuite
+
+        val matomoName = MatomoName.ReplyWithEuria.value


You don't need this variable anymore

FabianDevel · 2026-08-12T08:26:44Z

        Summarize("summarize"),
        Translate("translate"),
        AskEuria("askEuria"),
+        AskEuriaShortCut("askEuriaShortCut"),


AskEuriaQuickAction

FabianDevel · 2026-08-12T08:27:21Z

+    suspend fun Body.asPlainText(): String? {
+        // TODO: When the API handles blank characters, remove ifBlank
+        return when (type) {


Is it programmed that the back support this ?

FabianDevel · 2026-08-12T09:16:09Z

+                    isAdmin = mailbox?.isAdmin ?: false,
+                    matomoName = matomoName,
+                    substituteClassName = ThreadListFragment::class.java.name,
+                    onAvailable = { handleStandardReplyAction(messageUid) }


onAvailable isn't really clear, maybe onFeatureAvailable ?

…n opening euria prompt dialog # Conflicts: # app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt

sonarqubecloud · 2026-08-13T11:24:12Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions Bot assigned solrubado Jul 17, 2026

solrubado requested a review from Copilot July 17, 2026 12:19

Copilot started reviewing on behalf of solrubado July 17, 2026 12:20 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

solrubado force-pushed the reply-with-euria branch from 64cfff3 to 555b467 Compare July 17, 2026 13:04

Elouan1411 marked this pull request as ready for review July 24, 2026 10:56

Elouan1411 requested a review from Copilot July 24, 2026 10:56

Copilot started reviewing on behalf of Elouan1411 July 24, 2026 10:57 View session

Elouan1411 force-pushed the reply-with-euria branch from 6003d48 to becf9f6 Compare July 24, 2026 10:59

Copilot AI reviewed Jul 24, 2026

View reviewed changes

Elouan1411 force-pushed the reply-with-euria branch 3 times, most recently from a6f568a to dd955e6 Compare July 27, 2026 14:56

solrubado added 3 commits July 29, 2026 10:20

feat: Add reply Euria button and ask Euria icon on top bar

a188c82

fix: Remove euria bottom for thread actions

1b15ecd

feat: Add reply euria bottomsheet for threadFragment and open ai prop…

9a3fe64

…osition

Elouan1411 force-pushed the reply-with-euria branch from b6a2bd8 to e78ddbb Compare July 29, 2026 08:41

FabianDevel requested changes Aug 11, 2026

View reviewed changes

Elouan1411 and others added 12 commits August 11, 2026 16:08

refactor: Remove unused variable

571942b

refactor: Clean code with apply

d8ae85b

fix: Restart proposition when navigating to proposition fragment

c28baac

fix: Update and add copyright

dfb5208

fix: Improve mailbox logic and give last message content as context t…

752263a

…o ai proposition

feat: Add new body content payload

b3bf54b

feat: Insert AI suggestion in new message

3f2d2f8

fix: Use REPLY_ALL

1245efa

fix: Remove prompt when reopening bottom sheet

15e0877

fix: Make the "Edit my request" button work

115ce0f

fix: Do not use navigation to send the AI body

f6aabed

fix: Make the "retry" button work

f428c77

Elouan1411 and others added 16 commits August 11, 2026 17:03

feat: Add trailing content

04c31ff

feat: Add new feature badge

a9e2de1

fix: Add Copilot suggestions

6099986

fix: Load and convert message.body using the same plain-text logic be…

5d0a872

…fore starting generation

fix: Change check to see if aiPrompt is hosted by NewMessageActivity …

f4fd1d4

…or MainActivity

fix: Display new aiPrompt in loadingPlaceholder when using the "edit …

0a11853

…my request" button

feat: Add ask euria button

e3b66f2

fix: Replace date formatting to reduce space usage

55e5601

feat: Add matomo

9f2f2e3

refactor: Delete cache once it is no longer useful and remove the pair

7bedf9d

fix: Use email if name is not provided to avoid Euria error with empt…

90d5faf

…y values

feat: Display popup when no-reply address is detected

ac20d2d

fix: Change TEXT_PLAIN_WITHOUT_HTML to TEXT_PLAIN_WITH_HTML to preser…

0e68cca

…ve line breaks

feat: Dismiss bottom sheet when opening another one

42e0c4f

refactor: Clean code

9eb30d9

fix: Create functions in aiDraftCache

027671c

Elouan1411 force-pushed the reply-with-euria branch from 1641440 to 027671c Compare August 11, 2026 15:26

solrubado and others added 2 commits August 11, 2026 17:31

fix: Keep older code that explains better setCorrectSheetMargins func…

e936dee

…tion

refactor: Remove late init and clean code

246237b

FabianDevel requested changes Aug 12, 2026

View reviewed changes

solrubado force-pushed the reply-with-euria branch from 88f472a to b98a51f Compare August 12, 2026 08:41

Elouan1411 force-pushed the reply-with-euria branch from ffff0aa to 246237b Compare August 12, 2026 09:13

FabianDevel requested changes Aug 12, 2026

View reviewed changes

Elouan1411 added 2 commits August 12, 2026 11:45

refactor: Clean code

788d55a

refactor: Remove popBackStack

36d645d

Elouan1411 force-pushed the reply-with-euria branch from e2c8fd5 to 36d645d Compare August 12, 2026 10:33

Elouan1411 and others added 2 commits August 12, 2026 12:42

refactor: Use openKSuiteUpsellOrElse wherever the code is repeated

86d144b

refactor: Navigate directly instead of using backNavigationResult whe…

b319b0c

…n opening euria prompt dialog # Conflicts: # app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt

Uh oh!

Conversation

solrubado commented Jul 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FabianDevel Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

FabianDevel Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FabianDevel Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

FabianDevel Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FabianDevel Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

FabianDevel Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

FabianDevel Aug 12, 2026 • edited by Elouan1411 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FabianDevel Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Aug 13, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

FabianDevel Aug 12, 2026 •

edited

Loading

FabianDevel Aug 12, 2026 •

edited by Elouan1411

Loading