feat: Adapt reminder to backend changes - #3015
Open
Elouan1411 wants to merge 12 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adapts reminder-message handling to new backend status fields.
Changes:
- Adds reminder visibility fields to
Message. - Requests reminder status when fetching a message.
- Filters hidden reminders during thread recomputation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Message.kt |
Models backend reminder visibility fields. |
ThreadRecomputations.kt |
Filters reminder messages from displayed content. |
ApiRepository.kt |
Requests per-message reminder status. |
Elouan1411
force-pushed
the
adapt-with-new-backend
branch
from
August 5, 2026 15:09
9f1e490 to
d9d82b9
Compare
Elouan1411
marked this pull request as ready for review
August 6, 2026 11:31
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/refreshStrategies/ThreadRecomputations.kt:184
- Hidden reminders are only removed from
messagesWithContent, butThread.getDisplayedMessages()selects that list only when emoji reactions are available (ThreadExtensions.kt:83-85). In message mode, or for a mailbox withoutEMOJI_REACTION, it returnsmessages, so these reminders remain visible even whenRESPONSE_REQUIREDis enabled. The displayed-message selection needs to apply reminder filtering independently of the reactions feature.
val isHiddenReminder = message.shouldHideReminder
&& (isTargetMessageInThread(targetMessageIds, threadMessageIds) || message.isScheduledDraft)
if (isHiddenEmojiReaction.not() && isHiddenReminder.not()) messagesWithContent += message
app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/MessageController.kt:188
- This predicate is applied only when
searchQueryis nonblank. Filter-only searches are valid (SearchViewModel.computeSearchFiltersaccepts nonempty filters with an empty query), and the local fallback then executes theelsequery without this predicate, allowing hidden reminder records into results. Apply the reminder predicate to both branches.
val isNotHiddenReminder = "(${Message::isReminder.name} == false OR ${Message::displayReminder.name} == true)"
Elouan1411
force-pushed
the
adapt-with-new-backend
branch
from
August 7, 2026 13:01
1253209 to
6e09e8d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.