refactor(FileNameUtils): Make cache functions suspend

[FabianDevel]

No description provided.

[Copilot]

Pull request overview

Refactors attachment cache/path operations to run asynchronously on IO dispatchers.

Changes:

• Makes filename and cache helpers suspendable.
• Propagates suspend APIs through attachment actions.
• Updates UI callers to launch coroutines.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
LocalStorageUtils.kt	Moves upload and cache path work to IO.
FileNameUtils.kt	Makes contained-path resolution suspendable.
AttachmentExt.kt	Propagates suspend attachment operations.
AttachableExtensions.kt	Makes cache helpers suspendable.
NewMessageFragment.kt	Launches attachment opening asynchronously.
ThreadFragment.kt	Launches attachment opening asynchronously.
MessageWebViewClient.kt	Bridges cache lookups into synchronous interception.
CalendarEventBannerView.kt	Uses the view-tree lifecycle for attachment opening.
DownloadAttachmentViewModel.kt	Launches cache cleanup asynchronously.
DownloadAttachmentProgressDialog.kt	Resolves downloaded attachment intents asynchronously.
AttachmentActionsBottomSheetDialog.kt	Launches attachment actions asynchronously.

Suppressed comments (2)

app/src/main/java/com/infomaniak/mail/utils/FileNameUtils.kt:63

• This suspend signature also leaves FileNameUtilsTest.maliciousFileName_staysInsideExpectedDirectory calling the function from a non-suspend lambda, which fails test compilation. Update that test/helper to execute in a coroutine test context.

suspend fun File.resolveContainedFileName(untrustedName: String): File? = withContext(Dispatchers.IO) {

app/src/main/java/com/infomaniak/mail/ui/main/thread/actions/AttachmentActionsBottomSheetDialog.kt:102

• As above, the closing listener pops the bottom sheet before this coroutine starts. Once executeIntent suspends in cache resolution, destruction cancels this lifecycleScope, so saving a cached/server attachment to kDrive can silently do nothing. Keep the operation in a surviving scope with a surviving navigation owner, or defer closing until the asynchronous decision is complete.

                lifecycleScope.launch {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud