fix(tracing): return empty arrays for blocks without EVM transactions - #8
Closed
Ri-go wants to merge 1 commit into
Closed
fix(tracing): return empty arrays for blocks without EVM transactions#8Ri-go wants to merge 1 commit into
Ri-go wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesTraceBlock empty results
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Member
Author
|
Closing in favor of a smaller replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[]instead ofnullRationale
Injective chain initializes empty block trace results as a non-nil slice, so its JSON response is
[]. The v1.4.3 gateway alignment path started from a nil slice and returnednullwhen there were no visible transaction hashes. This restores chain-compatible output without changing the v1.4.3 transaction hash and alignment behavior.Testing
go test ./internal/evm/rpc/backend -run "TestTraceBlockWithoutEthereumTransactionsReturnsEmptyArray|TestAlignTraceBlockResultsWithVisibleTransactions|TestTraceBlockLatestSendsResolvedBlockContextHeight" -count=1go test ./...Summary by CodeRabbit
[]) instead of a null result.