Skip to content

ENH: Zero-initialize the matrix locals clang cannot prove are filled #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gdevenyi wants to merge 1 commit into from
Closed

ENH: Zero-initialize the matrix locals clang cannot prove are filled #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fsliolib/fslio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,7 +1756,7 @@ int FslGetIntensityScaling(FSLIO *fslio, float *slope, float *intercept)

mat33 mat44_to_mat33(mat44 x)
{
mat33 y;
mat33 y = { { { 0.0f } } };
int i,j;
for (i=0; i<3; i++) {
for (j=0; j<3; j++) {
Expand Down
8 changes: 4 additions & 4 deletions nifti2/nifti2_io.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2451,7 +2451,7 @@ float nifti_mat33_colnorm( mat33 A ) /* max column norm of 3x3 matrix */
nifti_dmat33 nifti_dmat33_mul( nifti_dmat33 A , nifti_dmat33 B )
/* multiply 2 3x3 matrices */
{
nifti_dmat33 C ; int i,j ;
nifti_dmat33 C = { { { 0.0 } } } ; int i,j ;
for( i=0 ; i < 3 ; i++ )
for( j=0 ; j < 3 ; j++ )
C.m[i][j] = A.m[i][0] * B.m[0][j]
Expand All @@ -2465,7 +2465,7 @@ nifti_dmat33 nifti_dmat33_mul( nifti_dmat33 A , nifti_dmat33 B )
*//*--------------------------------------------------------------------*/
mat33 nifti_mat33_mul( mat33 A , mat33 B ) /* multiply 2 3x3 matrices */
{
mat33 C ; int i,j ;
mat33 C = { { { 0.0f } } } ; int i,j ;
for( i=0 ; i < 3 ; i++ )
for( j=0 ; j < 3 ; j++ )
C.m[i][j] = A.m[i][0] * B.m[0][j]
Expand All @@ -2479,7 +2479,7 @@ mat33 nifti_mat33_mul( mat33 A , mat33 B ) /* multiply 2 3x3 matrices */
*//*--------------------------------------------------------------------*/
nifti_dmat44 nifti_dmat44_mul( nifti_dmat44 A , nifti_dmat44 B )
{
nifti_dmat44 C ; int i,j,k ;
nifti_dmat44 C = { { { 0.0 } } } ; int i,j,k ;
for( i=0 ; i < 4 ; i++ )
for( j=0 ; j < 4 ; j++ ) {
C.m[i][j] = 0.0;
Expand All @@ -2494,7 +2494,7 @@ nifti_dmat44 nifti_dmat44_mul( nifti_dmat44 A , nifti_dmat44 B )
*//*--------------------------------------------------------------------*/
mat44 nifti_mat44_mul( mat44 A , mat44 B )
{
mat44 C ; int i,j,k ;
mat44 C = { { { 0.0f } } } ; int i,j,k ;
for( i=0 ; i < 4 ; i++ )
for( j=0 ; j < 4 ; j++ ) {
C.m[i][j] = 0.0;
Expand Down
2 changes: 1 addition & 1 deletion niftilib/nifti1_io.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1887,7 +1887,7 @@ float nifti_mat33_colnorm( mat33 A ) /* max column norm of 3x3 matrix */
*//*--------------------------------------------------------------------*/
mat33 nifti_mat33_mul( mat33 A , mat33 B ) /* multiply 2 3x3 matrices */
{
mat33 C ; int i,j ;
mat33 C = { { { 0.0f } } } ; int i,j ;
for( i=0 ; i < 3 ; i++ )
for( j=0 ; j < 3 ; j++ )
C.m[i][j] = A.m[i][0] * B.m[0][j]
Expand Down
2 changes: 1 addition & 1 deletion niftilib/nifti_tester001.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ int main (int argc, const char *argv[])
nifti_datatype_sizes_test(DT_COMPLEX256,32,16);

{
mat44 R;
mat44 R = { { { 0.0f } } };
unsigned i,j;
for(i = 0; i < 4; i++)
for(j = 0; j < 4; j++)
Expand Down
Loading