Add implementation todo: Valkey-cached timeseries metadata for datapo… - #23
Open
olavgg wants to merge 2 commits into
Open
Add implementation todo: Valkey-cached timeseries metadata for datapo…#23olavgg wants to merge 2 commits into
olavgg wants to merge 2 commits into
Conversation
…int ingestion Captures the plan to take TimeseriesService.insertDatapoints()/deleteDatapoints() off the per-request PostgreSQL read (unpooled SimpleDriverDataSource) by caching the small timeseries metadata the hot path needs in Valkey, including cache-key tenant scoping, the invalidation points on save/update/delete, and the write-ACL staleness considerations. Design note only, no behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Olav Gjerde <olav@intellistream.ai>
datahub-lib-nodep is now datahub-commons and there is no datahub-library: ValkeyService lives in datahub-infra. The latest-datapoint cache is already tenant-scoped via latestDatapointKey, so the gotcha now says follow it rather than go hunting. Line references refreshed. Signed-off-by: samuel <samuel@intellistream.ai>
samuelhel
self-requested a review
August 27, 2026 08:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…int ingestion
Captures the plan to take TimeseriesService.insertDatapoints()/deleteDatapoints() off the per-request PostgreSQL read (unpooled SimpleDriverDataSource) by caching the small timeseries metadata the hot path needs in Valkey, including cache-key tenant scoping, the invalidation points on save/update/delete, and the write-ACL staleness considerations. Design note only, no behavior change.
What this changes
How it was verified
Checklist
git commit -s), per CONTRIBUTING.md./gradlew buildpasses(see AGENTS.md for which of the two documentation sites it belongs in)