Release/v0.2.0 - #101
Merged
Merged
Conversation
The ids in this module were all derived from one per-run number — `{id}`, `{id}_renamed` and
`{id + 1}` — and `delete_timeseries` cleared all three. A run whose number landed one away from
another's therefore deleted that run's series out from under it mid-test.
Every test now mints its ids with `unique_id`, so it only ever names series it created, and the
pre-delete each test opened with is gone: there is nothing left over to clear. The one exception is
the datapoint test, whose ids are deliberately fixed and shared with the test that reads back what
it inserts — it keeps its pre-delete, since a run that died before teardown does strand those.
The search test also gets a token per searched column. The indexed document concatenates name,
externalId and description, so a token shared with the external id let a hit on the description
prove nothing about the description. The query now carries the run's own token as well: bare words
AND together, and "SDK Test" alone matches every series the suite has ever created, which a
100-hit ranked cap can push the intended one off.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Bumps the three manifests the release workflow cross-checks against the tag. Fixes two things in the crate README first, since 0.2.0 is the first version ever published and that file becomes the front page on crates.io and docs.rs: the quick start called `search_by_name`, which went away with the search-contract refactor, and the dependency snippet advertised a version — 0.5 — that has never existed. `datahub_python_bindings/dist/` joins .gitignore. The existing entry is `/dist/`, anchored at the repository root, so the wheels build-local-wheels.sh leaves under the bindings directory showed up as untracked. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The two publish jobs both hung off `[crate, wheels]` and ran in parallel. Neither registry will accept a version twice, so a PyPI failure alongside a crates.io success left the version half released and unrecoverable — the only way forward being to abandon the number and tag the next one. Serializing them costs a few minutes on release runs and confines that to one direction: if PyPI rejects the upload, crates.io never runs and the version is still free. PyPI is the half worth guarding, since its trusted publisher is newer than the crates.io token. Both jobs carry the same tag guard, so a skipped `pypi` on the pull-request rehearsal skips `crates-io` with it, as before. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.