fix: drop a rejected token on 401 so the next call re-mints - #105
Merged
Conversation
The client cached its token and only refreshed on expiry, so a token the server rejects was re-sent until it expired. Expiry is not the only way a token stops being usable: an identity provider still finishing its setup can issue one the API refuses for its whole lifetime — a malformed `organization` claim, say. A client that started a few seconds too early therefore stayed broken for up to an hour instead of recovering on its next attempt. Clear the cached token when a request comes back 401, so the next call mints a fresh one. The failing call still fails; callers that retry now succeed. Verified against the suite: no new failures, and two timeseries tests that were dying on an unrecoverable 401 now pass (127->132 passing). Signed-off-by: samuel <samuel@intellistream.ai>
olavgg
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client cached its token and only refreshed on expiry, so a token the server rejects was re-sent until it expired. Expiry is not the only way a token stops being usable: an identity provider still finishing its setup can issue one the API refuses for its whole lifetime — a malformed
organizationclaim, say. A client that started a few seconds too early therefore stayed broken for up to an hour instead of recovering on its next attempt.Clear the cached token when a request comes back 401, so the next call mints a fresh one. The failing call still fails; callers that retry now succeed.
Verified against the suite: no new failures, and two timeseries tests that were dying on an unrecoverable 401 now pass (127->132 passing).