LDAP: add fallback to mailPrimaryAddress when determining user domain#1508
Open
erik-saarts wants to merge 2 commits into
Open
LDAP: add fallback to mailPrimaryAddress when determining user domain#1508erik-saarts wants to merge 2 commits into
erik-saarts wants to merge 2 commits into
Conversation
Member
|
Hi, Thanks for the PR! I've looked into it and it seems it would be even better if we'd use the LDAP mapping values (https://groupoffice.readthedocs.io/en/latest/system-settings/authentication/ldap.html#mapping) won't you agree? Best regards, |
Author
|
100% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When syncing LDAP users, GroupOffice determines the user domain from the DN and falls back to the LDAP "mail" attribute when the DN-derived domain is not configured.
Univention Corporate Server (UCS) stores the primary email address in "mailPrimaryAddress" instead of "mail".
This change keeps the existing behavior unchanged and adds "mailPrimaryAddress" as a fallback before failing.
Tested with LDAP setup where:
Result: