Skip to content

docs(core): document review repo enrollment setup (BRIX-2004) - #154

Open
quay-worker[bot] wants to merge 1 commit into
devfrom
quay/BRIX-2004
Open

docs(core): document review repo enrollment setup (BRIX-2004)#154
quay-worker[bot] wants to merge 1 commit into
devfrom
quay/BRIX-2004

Conversation

@quay-worker

@quay-worker quay-worker Bot commented Aug 11, 2026

Copy link
Copy Markdown

Summary

  • Document the full runtime checklist for enabling Quay PR review enrollment on private repos.
  • Live registry update applied for emusd-monorepo: repo_id=emusd-monorepo, URL https://github.com/InverterNetwork/emusd-monorepo, base dev, package manager bun, install bun install, reviewer guidance preamble_reviewer=9.
  • Verification found the remaining blocker: the current Hermes/Quay GitHub App token cannot read InverterNetwork/emusd-monorepo, so the bare clone and review request could not be completed yet.

Deployment Steps

⚠️ Manual deployment steps needed, will not be operational unless the following steps are taken:

  1. Grant the Hermes/Quay GitHub App installation access to InverterNetwork/emusd-monorepo.
  2. If the registry row is missing in a target environment, add it with QUAY_DATA_DIR="{env_QUAY_DATA_DIR}" quay repo add --id emusd-monorepo --url https://github.com/InverterNetwork/emusd-monorepo --base-branch dev --package-manager bun --install-cmd "bun install".
  3. Materialize the bare clone with git clone --bare https://github.com/InverterNetwork/emusd-monorepo "{env_QUAY_REPOS_ROOT}/emusd-monorepo.git".
  4. Enqueue the requested review with HERMES_QUAY_GITHUB_AUTH_REPOS=InverterNetwork/emusd-monorepo quay-as-hermes review-pr --pr InverterNetwork/emusd-monorepo:20.

Verification should confirm step 4 no longer emits GitHub Not Found, bare_clone_missing, or repo_not_configured.

Test Plan

Pre-merge checklist

  • bun test packages/cli/tests/schema/migrations.test.ts
  • bun test packages/cli/tests/repo/repo_list_export_import.test.ts
  • bun test packages/cli/tests/review/pr_review_entry.test.ts
  • Live registry check shows active emusd-monorepo row in /home/hermes/.hermes/quay.

Post-deployment verification

  • Grant GitHub App access and materialize {env_QUAY_REPOS_ROOT}/emusd-monorepo.git.
  • Run HERMES_QUAY_GITHUB_AUTH_REPOS=InverterNetwork/emusd-monorepo quay-as-hermes review-pr --pr InverterNetwork/emusd-monorepo:20 and confirm the review request is enqueued.

@linear

linear Bot commented Aug 11, 2026

Copy link
Copy Markdown

BRIX-2004

@quay-reviewer quay-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Findings

Blocking

🔴 [1] Review enrollment is still not operational for the requested repo
The task is to add Quay support for InverterNetwork/emusd-monorepo so quay-as-hermes review-pr --pr InverterNetwork/emusd-monorepo:20 can be enqueued successfully. This PR only adds a generic runtime checklist in repositories.md:64-104, while the PR body says the current Hermes/Quay GitHub App token still cannot read the repo and the bare clone/review request remain manual follow-up steps. That leaves the live deployed path in the same unusable state for the requested review, just with instructions for someone else to complete later. Complete and verify the live GitHub App access, bare clone materialization, and review-pr enqueue before merging this task.

Changes that claim to enable a deployed integration must complete and verify every runtime prerequisite needed for the target command to succeed; documenting required follow-up is not enough when the acceptance criteria require operational readiness.

Non-blocking

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants