docs(core): document review repo enrollment setup (BRIX-2004) - #154
docs(core): document review repo enrollment setup (BRIX-2004)#154quay-worker[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Review Findings
Blocking
🔴 [1] Review enrollment is still not operational for the requested repo
The task is to add Quay support for InverterNetwork/emusd-monorepo so quay-as-hermes review-pr --pr InverterNetwork/emusd-monorepo:20 can be enqueued successfully. This PR only adds a generic runtime checklist in repositories.md:64-104, while the PR body says the current Hermes/Quay GitHub App token still cannot read the repo and the bare clone/review request remain manual follow-up steps. That leaves the live deployed path in the same unusable state for the requested review, just with instructions for someone else to complete later. Complete and verify the live GitHub App access, bare clone materialization, and review-pr enqueue before merging this task.
Changes that claim to enable a deployed integration must complete and verify every runtime prerequisite needed for the target command to succeed; documenting required follow-up is not enough when the acceptance criteria require operational readiness.
Non-blocking
None.
Summary
emusd-monorepo:repo_id=emusd-monorepo, URLhttps://github.com/InverterNetwork/emusd-monorepo, basedev, package managerbun, installbun install, reviewer guidancepreamble_reviewer=9.InverterNetwork/emusd-monorepo, so the bare clone and review request could not be completed yet.Deployment Steps
InverterNetwork/emusd-monorepo.QUAY_DATA_DIR="{env_QUAY_DATA_DIR}" quay repo add --id emusd-monorepo --url https://github.com/InverterNetwork/emusd-monorepo --base-branch dev --package-manager bun --install-cmd "bun install".git clone --bare https://github.com/InverterNetwork/emusd-monorepo "{env_QUAY_REPOS_ROOT}/emusd-monorepo.git".HERMES_QUAY_GITHUB_AUTH_REPOS=InverterNetwork/emusd-monorepo quay-as-hermes review-pr --pr InverterNetwork/emusd-monorepo:20.Verification should confirm step 4 no longer emits GitHub
Not Found,bare_clone_missing, orrepo_not_configured.Test Plan
Pre-merge checklist
bun test packages/cli/tests/schema/migrations.test.tsbun test packages/cli/tests/repo/repo_list_export_import.test.tsbun test packages/cli/tests/review/pr_review_entry.test.tsemusd-monoreporow in/home/hermes/.hermes/quay.Post-deployment verification
{env_QUAY_REPOS_ROOT}/emusd-monorepo.git.HERMES_QUAY_GITHUB_AUTH_REPOS=InverterNetwork/emusd-monorepo quay-as-hermes review-pr --pr InverterNetwork/emusd-monorepo:20and confirm the review request is enqueued.