Improve server version parsing for Minecraft 26.1+ builds#34
Open
Despical wants to merge 1 commit intoIridium-Development:masterfrom
Open
Improve server version parsing for Minecraft 26.1+ builds#34Despical wants to merge 1 commit intoIridium-Development:masterfrom
Despical wants to merge 1 commit intoIridium-Development:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes server version parsing in
IridiumColorAPIfor newer server version formats, including26.1+builds.What was happening
IridiumColorAPI#getVersion()was using a fragile parsing approach that assumed older version formats such as1.x.x-R0.1-SNAPSHOT.With newer server versions, version strings can include different formats such as:
26.1.2-R0.1-SNAPSHOT26.1.2-49-main@7799bf2 (2026-04-26T20:59:50Z)git-Paper-43 (MC: 1.20.1)Because of that, the old logic could extract invalid substrings like
.1and throw aNumberFormatExceptionduring static initialization.What changed
getVersion()to extract the major version more safely1.x.xstyle versions26.1+style buildsDependency metadata
This PR also updates the Spigot dependency setup so it is no longer published as a transitive runtime dependency.
The library only needs the Bukkit/Spigot API at compile time, while tests still keep access to it through the test configuration.