fix: keep the latest instance search results - #14
Open
Hanabi9248 wants to merge 2 commits into
Open
Hanabi9248 wants to merge 2 commits into
Hanabi9248 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching twice, or searching and then resetting, can leave the instance table showing an older response if requests finish out of order. A late reset response can also restart polling after a newer search has stopped it.
Use one request counter for Search and Reset, and ignore results and errors from superseded requests before emitting resultList.
Added four regression cases covering reversed search/search, search/reset and reset/search responses, plus stale errors. All four fail before the fix; the full suite passes afterward (8 tests, Node 18). ESLint has no errors; its two warnings concern the fixed method-name table in the test.