Harden pcatR summaries, suppression, and PDF export before CRAN#4
Merged
Conversation
JaeManP
force-pushed
the
codex/precran-analytic-hardening
branch
from
July 19, 2026 03:48
3f89a5c to
43ae025
Compare
JaeManP
marked this pull request as ready for review
July 19, 2026 03:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft hardens the pcatR 1.0.1 pre-CRAN candidate by correcting:
n_neutral_complete;pcat_class5;pct_complete_classas the share of valid-direction records with a complete five-category classification;modal_classis hidden with numeric analytic results;NA, not confirmedFALSE;Why
The previous implementation could produce a complete-category distribution above 100%, expose a modal response classification in a suppressed cell, assign a valid-looking strength to an invalid direction, leave a partial PDF after a later-page failure, unintentionally accept vector threshold inputs, document a completeness field that was absent from the API, and potentially rename an existing directory supplied as an overwrite target.
Methodological boundaries
Repository integration
main.c1a93994633a94608238565e8f893a797d8e32a7.43ae025a491ce6ebde713b1431588a983155c83b.Local verification
devtools::test(stop_on_failure = TRUE): 236 expectations, 0 failures, 0 errors, 0 warnings, 0 skips.pcat_self_test(): 25/25 passing.devtools::check(cran = FALSE, error_on = "never"): 0 errors, 0 warnings, 0 notes.pcatR_1.0.1.tar.gz.a8ee1f3e02861eda11281e4390207335339dd4312cf17ab69bf4a925eee44377.R CMD check --as-cranon the exact local archive: 0 errors, 0 warnings, 3 explained notes (new submission, host clock unavailable, and the local R 4.4 validator rejecting R-generated HTML5 elements).Current GitHub Actions verification
Exact restacked head under test:
43ae025a491ce6ebde713b1431588a983155c83b.29672326904— passed.29672326903— passed; overall line coverage: 84.86%.29672326930— passed; deployment was intentionally skipped for this draft PR.88153490605.88153566507; R-devel88153566514.8437716422, namepcatR-1.0.1-source.8437732735; R-devel ID8437733655.8437718938.pcatR_1.0.1.tar.gz.61c549ae6ebc764f0471bda85cae7cccf710276b4a4ef99053afe7b7059b79b9.pcatR_1.0.1.sha256agrees with the independently downloaded archive.The completed pre-restack workflow identifiers and artifacts have been superseded by this exact-head run set and are not presented as current evidence.
Remaining external gates
v1.0.1tag and GitHub Release.This PR does not submit the package to CRAN, does not run or claim Win-builder validation, does not freeze the final submission archive, and does not create a release tag.