Fix CI failures#509
Merged
Merged
Conversation
nathanwbrei
force-pushed
the
nbrei_ci_fixes
branch
2 times, most recently
from
5f1d518 to
850c693
Compare
Also, JLogger::Level::FATAL now canonicalizes to "critical" to avoid wacky race conditions caused by different default values. This was inspired by an issue caused by the parameter names for the JANA2 logger service colliding with those used by ePIC's spdlog service. It's desirable for the same parameter to control both loggers, but we need a smoother on-ramp. This brings us into closer agreement with spdlog, which might eventually supplant the JLogger completely.
Addresses issue #496
nathanwbrei
force-pushed
the
nbrei_ci_fixes
branch
from
b138d6c to
651d622
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
Exception in JFactory::Create, ...printouts #496