feat: add generic EVIO+HIPO reader service#1256
Open
baltzell wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new CLARA I/O service (Clas12Reader) intended to read either EVIO or HIPO files and forward events unchanged, selecting the backend reader based on the input filename suffix. This is positioned as a simpler replacement for the prior “DecoderReader + HipoToHipoReader” behavior and a building block for the upcoming multi-threaded decoding work (see #1229).
Changes:
- Introduces
org.jlab.io.clara.Clas12Readerto read EVIO viaEvioSourceor HIPO viaHipoReaderand expose the correspondingEngineDataType. - Adds a CLARA service descriptor
Clas12Reader.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| common-tools/clara-io/src/main/java/org/jlab/io/clara/Clas12Reader.java | New generic EVIO/HIPO reader service with suffix-based backend selection and event passthrough. |
| common-tools/clara-io/src/main/resources/org/jlab/io/clara/Clas12Reader.yaml | Registers the new Clas12Reader service for CLARA deployment. |
Comments suppressed due to low confidence (1)
common-tools/clara-io/src/main/java/org/jlab/io/clara/Clas12Reader.java:70
- There is dead/commented-out code returning an EvioDataEvent, and the EvioDataEvent import becomes unused. Please remove the commented line (and the unused import) to avoid confusion about the intended EVIO payload type.
return ((EvioSource)reader).getEventBuffer(eventNumber, true);
//return new EvioDataEvent(b.array(), readByteOrder());
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
Clas12ReaderisEvioToEvioReader + HipoToHipoReader, currently chosen at runtime based on.hipofile suffix. This will become useful with the (multi-threaded)DecoderEnginein #1229.The previous
Clas12ReaderwasDecoderReader + HipoToHipoReader. That was a bit confusing and could be restored with a different name, probablyClas12Decoderfits.