Sqlitecpp rework#132
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131
RCDB previously bundled a modified copy of SQLiteCpp (v2.0.0) as an amalgamation in its headers. This caused duplicate-symbol / ODR clashes for projects like
halld_reconthat also use their own SQLiteCpp. This PR removes the vendored copy and switches to SQLiteCpp as a normal external dependency, resolved via modern CMake best practices.Changes
No breaking changes to RCDB's public C++ API
The RCDB headers themselves are unchanged (still header-only for reading RCDB).