Skip to content

ci: delegate image publishing to Argo - #169

Merged
Johnaverse merged 1 commit into
mainfrom
chore/reduce-github-actions
Sep 4, 2026
Merged

ci: delegate image publishing to Argo#169
Johnaverse merged 1 commit into
mainfrom
chore/reduce-github-actions

Conversation

@Johnaverse

Copy link
Copy Markdown
Owner

Summary

  • Add the repository-owned Argo build profile.
  • Keep pull-request lint, tests, coverage, and OpenAPI drift validation.
  • Remove hosted Docker build and GHCR publication.
  • Bump the application and OpenAPI version to 1.7.36.
  • Replace expired future-date fixtures with stable future dates.

Coordinated rollout

Pair with the johnaverse-fleet PR that enables chains-api in the Argo build poller.

Validation

  • lint passed
  • Vitest coverage: 1,147 passed, 4 skipped
  • generated OpenAPI document matches version 1.7.36
  • build profile validation passed
  • actionlint and YAML parsing passed
  • git diff --check and added-line secret scan passed

Copilot AI lite review requested due to automatic review settings September 3, 2026 23:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The CI workflow trigger/pipeline changes appear to diverge from repository documentation and remove any visible SonarQube scan path, which should be reconciled or documented before merging.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR shifts container image publishing responsibilities from GitHub Actions to an Argo-driven build/poller workflow by introducing a repo-owned build profile, while retaining pull-request verification (lint/tests/coverage/OpenAPI drift checks). It also bumps the service/OpenAPI version to 1.7.36 and updates time-sensitive test fixtures to stable future dates.

Changes:

  • Add .johnaverse/build.yaml to describe the Argo build inputs (version source + Docker image build context).
  • Convert the existing Docker workflow into PR-only checks by removing GHCR build/publish and push/tag triggers.
  • Bump version to 1.7.36 across package.json, package-lock.json, and public/openapi.json, and refresh fork test fixtures to avoid expiring dates.
File summaries
File Description
tests/unit/services/forks.test.js Updates fork activation fixture dates to stable far-future timestamps to keep tests from expiring.
public/openapi.json Bumps the published OpenAPI info.version to 1.7.36.
package.json Bumps application version to 1.7.36.
package-lock.json Keeps lockfile metadata in sync with the 1.7.36 version bump.
.johnaverse/build.yaml Adds an Argo build profile describing the image build context and version source.
.github/workflows/docker-build.yml Removes Docker build/push and narrows the workflow to PR checks + manual dispatch.
Review details
  • Files reviewed: 5/6 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 3 to 7
on:
push:
branches:
- main
tags:
- 'v*'
pull_request:
branches:
- main
workflow_dispatch:
@Johnaverse
Johnaverse merged commit 1a511e6 into main Sep 4, 2026
5 checks passed
@Johnaverse
Johnaverse deleted the chore/reduce-github-actions branch September 4, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants