Skip to content

Urldecode to filename - #92

Open
ideea wants to merge 2 commits into
JosephSilber:masterfrom
ideea:patch-1
Open

Urldecode to filename#92
ideea wants to merge 2 commits into
JosephSilber:masterfrom
ideea:patch-1

Conversation

@ideea

@ideea ideea commented Jan 10, 2022

Copy link
Copy Markdown

In case, when url contains utf8 symbols, Nginx cache won't work, cause files will be saved with encoded name.

In case, when url contains utf8 symbols, Nginx cache won't work, cause files will be saved with encoded name.
@ugido

ugido commented Jan 12, 2022

Copy link
Copy Markdown

This is only one part of the solution.
The other part is to adjust the path and filename in method cache (or better in getDirectoryAndFileNames) in src/Cache Class.

#79 (comment)

To test it, use a path containing special characters like german letters äöü...

@ideea

ideea commented Jan 13, 2022

Copy link
Copy Markdown
Author

yes, you are right, thanks.

@ideea

ideea commented Jan 13, 2022

Copy link
Copy Markdown
Author

@JosephSilber ping? :)

@alignwebs

Copy link
Copy Markdown

@JosephSilber is this repo still active or should we fork it?

@JosephSilber

Copy link
Copy Markdown
Owner

is this repo still active

Yes.

I work on open source in my free time. Unless there are truly show-stopping bugs, I don't generally review issues/PRs every day. I work on my open source projects in chunks of time, whenever I have the time available.

The next opportunity I have to dedicate a chunk of time to this project (hopefully later this week), I'll review this PR.

@JosephSilber

Copy link
Copy Markdown
Owner

hopefully later this week

🤣

Anyhow, how do you handle this in the Apache/nginx configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants