Skip to content

Remove quirks that never apply - #1097

Merged
maleadt merged 2 commits into
mainfrom
tb/dead-quirks
Sep 24, 2026
Merged

maleadt merged 2 commits into
mainfrom
tb/dead-quirks

Conversation

@maleadt

@maleadt maleadt commented Sep 23, 2026

Copy link
Copy Markdown
Member

Base.Checked.throw_overflowerr_negation and Base.Math.throw_exp_domainerror take a single argument on every supported version of Julia (1.10 through nightly), so the overrides in quirks.jl with more arguments never matched. Found by checking the signature of every method in the overlay method table against the methods in Base; these were the only ones that don't match anything. The dead throw_overflowerr_negation override exists in the other back-ends too, which get the same fix.

Base.Checked.throw_overflowerr_negation and Base.Math.throw_exp_domainerror
take a single argument on every supported version of Julia, so the
overrides with more arguments never matched.
@luraess

luraess commented Sep 23, 2026

Copy link
Copy Markdown
Member

cscs-ci run

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMDGPU.jl Benchmarks

Details
Benchmark suite Current: bb633bb Previous: 8a66547 Ratio
amdgpu/synchronization/context/device 545 ns 550 ns 0.99
amdgpu/synchronization/stream/blocking 215 ns 222.5 ns 0.97
amdgpu/synchronization/stream/nonblocking 297.5 ns 307.5 ns 0.97
applications/bitonic_sort 1150938.5 ns 1160103.75 ns 0.99
applications/convolution 72886 ns 72376 ns 1.01
applications/floyd_warshall 9065267.5 ns 9100856.25 ns 1.00
applications/histogram 786131 ns 798998.75 ns 0.98
applications/prefix_sum 190420.25 ns 190535 ns 1.00
array/accumulate/Float32/1d 75426.25 ns 79346 ns 0.95
array/accumulate/Float32/dims=1 282444 ns 271536.25 ns 1.04
array/accumulate/Float32/dims=1L 80528.5 ns 72536 ns 1.11
array/accumulate/Float32/dims=2 75573.5 ns 74041 ns 1.02
array/accumulate/Float32/dims=2L 3028025.25 ns 2834326.75 ns 1.07
array/accumulate/Int64/1d 78841.25 ns 79098.5 ns 1.00
array/accumulate/Int64/dims=1 249408.5 ns 248393.25 ns 1.00
array/accumulate/Int64/dims=1L 89253.75 ns 89128.75 ns 1.00
array/accumulate/Int64/dims=2 76153.75 ns 76041 ns 1.00
array/accumulate/Int64/dims=2L 3393062.75 ns 3139866 ns 1.08
array/broadcast 75808.5 ns 50443.25 ns 1.50
array/construct 2017.5 ns 2247.5 ns 0.90
array/copy 40168.25 ns 39278 ns 1.02
array/copyto!/cpu_to_gpu 85933.75 ns 85676.25 ns 1.00
array/copyto!/gpu_to_cpu 85921.25 ns 85591.25 ns 1.00
array/copyto!/gpu_to_gpu 58665.75 ns 58288.25 ns 1.01
array/iteration/findall/bool 133314.25 ns 125954.25 ns 1.06
array/iteration/findall/int 148749.75 ns 146617 ns 1.01
array/iteration/findfirst/bool 157779.75 ns 155292.25 ns 1.02
array/iteration/findfirst/int 191862.75 ns 189260 ns 1.01
array/iteration/findmin/1d 101334 ns 103258.75 ns 0.98
array/iteration/findmin/2d 90733.75 ns 90081.25 ns 1.01
array/iteration/logical 229988.25 ns 226565.5 ns 1.02
array/iteration/scalar 309776.75 ns 295931.5 ns 1.05
array/permutedims/2d 48318.25 ns 70736 ns 0.68
array/permutedims/3d 69938.5 ns 69253.5 ns 1.01
array/permutedims/4d 75806 ns 50278.25 ns 1.51
array/random/rand/Float32 46508.25 ns 40065.75 ns 1.16
array/random/rand/Int64 56003.25 ns 48863 ns 1.15
array/random/rand!/Float32 45865.75 ns 65541 ns 0.70
array/random/rand!/Int64 53565.75 ns 69623.25 ns 0.77
array/random/randn/Float32 71671 ns 71161 ns 1.01
array/random/randn!/Float32 69853.5 ns 58721 ns 1.19
array/reductions/mapreduce/Float32/1d 79448.75 ns 81621 ns 0.97
array/reductions/mapreduce/Float32/dims=1 73931 ns 56660.75 ns 1.30
array/reductions/mapreduce/Float32/dims=1L 838694.25 ns 844514.25 ns 0.99
array/reductions/mapreduce/Float32/dims=2 75141 ns 74073.5 ns 1.01
array/reductions/mapreduce/Float32/dims=2L 137517 ns 136524.5 ns 1.01
array/reductions/mapreduce/Int64/1d 82716 ns 81663.5 ns 1.01
array/reductions/mapreduce/Int64/dims=1 74018.5 ns 73933.5 ns 1.00
array/reductions/mapreduce/Int64/dims=1L 845047 ns 839174.25 ns 1.01
array/reductions/mapreduce/Int64/dims=2 76866 ns 75486.25 ns 1.02
array/reductions/mapreduce/Int64/dims=2L 138527 ns 137611.75 ns 1.01
array/reductions/reduce/Float32/1d 82571 ns 81541.25 ns 1.01
array/reductions/reduce/Float32/dims=1 75416.25 ns 70296 ns 1.07
array/reductions/reduce/Float32/dims=1L 841237 ns 836984.25 ns 1.01
array/reductions/reduce/Float32/dims=2 76873.5 ns 75123.5 ns 1.02
array/reductions/reduce/Float32/dims=2L 137196.75 ns 136774.25 ns 1.00
array/reductions/reduce/Int64/1d 82483.75 ns 81368.75 ns 1.01
array/reductions/reduce/Int64/dims=1 74388.5 ns 74831 ns 0.99
array/reductions/reduce/Int64/dims=1L 844804.25 ns 844554 ns 1.00
array/reductions/reduce/Int64/dims=2 75916 ns 75411.25 ns 1.01
array/reductions/reduce/Int64/dims=2L 138384.5 ns 137047 ns 1.01
array/reverse/1d 44540.75 ns 43458 ns 1.02
array/reverse/1dL 71876 ns 70606 ns 1.02
array/reverse/1dL_inplace 56653.25 ns 79671 ns 0.71
array/reverse/1d_inplace 51425.5 ns 60390.75 ns 0.85
array/reverse/2d 48308.25 ns 47625.75 ns 1.01
array/reverse/2dL 75028.75 ns 57993.5 ns 1.29
array/reverse/2dL_inplace 79863.75 ns 79096 ns 1.01
array/reverse/2d_inplace 63688.25 ns 61191 ns 1.04
array/sorting/1d 326572 ns 326449.5 ns 1.00
gemm/tiled 1933772.25 ns 1961659.75 ns 0.99
gemm/tiled_unbounded 1937149.75 ns 1960334.75 ns 0.99
integration/byval/reference 40191 ns 39821 ns 1.01
integration/byval/slices=1 40010 ns 40830 ns 0.98
integration/byval/slices=2 135712 ns 130842 ns 1.04
integration/byval/slices=3 241154 ns 241884 ns 1.00
integration/volumerhs 4876789 ns 4900148 ns 1.00
kernel/indexing 33940.5 ns 41880.5 ns 0.81
kernel/indexing_checked 43253 ns 37075.5 ns 1.17
kernel/launch 1245 ns 1130 ns 1.10
kernel/rand 69476 ns 70343.5 ns 0.99
latency/import 1453418259 ns 1456646355 ns 1.00
latency/precompile 22642849628 ns 22642954217 ns 1.00
latency/ttfp 2241561152 ns 2251455325 ns 1.00
stencil/diffusion3d 1614530.25 ns 1611230 ns 1.00
stencil/diffusion3d_checked 1658423.25 ns 1655470.5 ns 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@maleadt
maleadt merged commit f72c6b7 into main Sep 24, 2026
5 of 6 checks passed
@maleadt
maleadt deleted the tb/dead-quirks branch September 24, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants