Skip broken MIOpen XDLOPS conv solvers on gfx90a too, and move the workaround into the test - #1103
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ree codegen kernel Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merging this as the fix only targets MI250/MI300 hardware for which tests are passing. It also brings MI250X pipeline into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hip_dnn/convsegfaults on gfx90a (MI250X). The worker dies withsignal 11, so the whole testset is lost. The cause is upstream: MIOpen's CK grouped-conv XDLOPS solvers (ROCm/rocm-libraries#9088). gfx942 CI only stays green because of fiveMIOPEN_DEBUG_*vars inci/cscs-mi300.ymland a backward-data skip gated on"gfx942".This PR:
test/hip_dnn/conv.jlto gfx90a;get!, so a value already in the environment still wins. A plainPkg.testnowworks outside CI;
ci/cscs-mi300.yml, so CI exercises the test-side path.Findings
Problem: the first case of
conv.jl(3×3 input, 3×3 filter, 1 channel, NCHW), with the beverin uenvprgenv-gnu/7.2.3(MIOpen 3.5.1). Results are identical on gfx90a (MI250X) and gfx942 (MI300A):ConvHipImplicitGemmGroupFwdXdlopshipLaunchKernelMIOPEN_DEBUG_GROUP_CONV_IMPLICIT_GEMM_HIP_FWD_XDLOPS=0ConvHipImplicitGemmGroupWrwXdlopsMIOPEN_DEBUG_GROUP_CONV_IMPLICIT_GEMM_HIP_WRW_XDLOPS=0ConvHipImplicitGemmGroupBwdXdlopshipLaunchKernelMIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_GROUP_BWD_XDLOPS=1(inverted;=0does not disable it)MIOpenDriveralone reproduces it, without Julia./opt/rocm-7.2.3, and passes all 27 conv tests, backward-data included.=1fixes the 2D case inMIOpenDriver. The 3D backward-data solver isn't checked.Reproducer (inside the uenv):
Testing
hip_dnnsuite on beverin MI250X (gfx90a), run with noMIOPEN_DEBUG_*vars set:The 4 broken results are the skipped backward-data calls. The gfx942 path is covered by this PR's CSCS MI300 CI run, which no longer gets the vars from the yml.