Conversation
maleadt
added this pull request to stack #944
September 24, 2026 15:38
maleadt
force-pushed
the
tb/atomics-unsupported
branch
from
September 24, 2026 16:15
6146418 to
dfd9510
Compare
maleadt
removed this pull request from stack #944
September 25, 2026 06:14
maleadt
force-pushed
the
tb/atomics-unsupported
branch
from
September 25, 2026 06:14
dfd9510 to
0d0e759
Compare
maleadt
added this pull request to stack #951
September 25, 2026 06:14
maleadt
force-pushed
the
tb/atomics-unsupported
branch
from
September 25, 2026 06:55
0d0e759 to
75dd53c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## tb/atomics #943 +/- ##
===========================================
Coverage 87.15% 87.15%
===========================================
Files 30 30
Lines 6277 6285 +8
===========================================
+ Hits 5471 5478 +7
- Misses 806 807 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
`validate_ir` rejects the atomics that Metal cannot express, but when validation is disabled (e.g., by `code_native` and the other reflection macros), `lower_atomics!` selected them anyway, to AIR intrinsics that don't exist (such as `air.atomic.global.store.i64`). Leave unsupported operations alone instead, and report them after the lowering with the same reasons and backtraces as `validate_ir`. The fence lowering test relied on this, with a 64-bit atomic store.
maleadt
force-pushed
the
tb/atomics-unsupported
branch
from
September 25, 2026 11:01
75dd53c to
e6cbee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_irrejects the atomics that Metal can't express. When validation is disabled, e.g. bycode_nativeand the other reflection functions,lower_atomics!used to select them anyway, to AIR intrinsics that don't exist (such asair.atomic.global.store.i64). Now it leaves unsupported operations alone and reports them after the lowering as anInvalidIRError, with the same reasons and backtraces asvalidate_ir.Compilations that validate are unaffected. The only case that changes is reflection on a kernel that couldn't be compiled anyway: it now shows why, instead of printing an intrinsic that doesn't exist. One of our own tests depended on that, with a 64-bit atomic store in the fence lowering test; it now uses a 32-bit store.