Dev KernelInterface on Windows too - #775
Merged
Merged
Conversation
Julia 1.10 ignores `[sources]`, so it resolves KernelInterface from the registry rather than from lib/KernelInterface. The "Dev KernelInterface" step compensates, but it was gated on `runner.os != 'Windows'`, copied from the neighboring runtest step; only the test run needs the de-escalated shell, not `Pkg.develop`. As a result the 1.10 Windows job picked up the registered KernelInterface v0.1.0, which lacks `record_event`, and KernelAbstractions failed to precompile with `UndefVarError: record_event not defined`. Run the step everywhere, under bash so the quoting works on Windows. Assisted-by: Claude Code (Opus 5)
`[sources]` is only supported from Julia 1.11 on. On 1.10 the entry pointing KernelInterface at lib/KernelInterface is silently ignored and Pkg resolves it from the registry, so the dev step is what keeps 1.10 testing this repo's copy. Record that where the step is, and cross-reference it from the OpenCL job, which dev's KernelInterface for the same reason. Assisted-by: Claude Code (Opus 5)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 62.74% 63.72% +0.97%
==========================================
Files 22 23 +1
Lines 1914 1935 +21
==========================================
+ Hits 1201 1233 +32
+ Misses 713 702 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from #750