Skip to content

Do not emit aliasscope markers on Julia 1.11 and later #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vchuravy wants to merge 2 commits into
base: release-0.9
Choose a base branch
from
+18 −12
Open

Do not emit aliasscope markers on Julia 1.11 and later #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1bcf3f
Do not emit aliasscope markers on Julia 1.11 and later
vchuravy Sep 12, 2026
24609fb
Skip alias scope metadata test when markers are not emitted
vchuravy Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/macros.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ function __kernel(expr, generate_cpu = true, force_inbounds = false, unsafe_indi
end
end

# Julia 1.11 and later miscompile code placed inside an `aliasscope`, even when the
# kernel makes no use of `@Const`, so the markers are only emitted on older versions.
# See https://github.com/JuliaGPU/KernelAbstractions.jl/issues/652
# and https://github.com/JuliaLang/julia/issues/63129
const EMIT_ALIASSCOPE = VERSION < v"1.11-"

# The easy case, transform the function for GPU execution
# - mark constant arguments by applying `constify`.
function transform_gpu!(def, constargs, force_inbounds, unsafe_indices)
Expand All @@ -91,10 +97,8 @@ function transform_gpu!(def, constargs, force_inbounds, unsafe_indices)
pushfirst!(def[:args], :__ctx__)
new_stmts = Expr[]
body = MacroTools.flatten(def[:body])
# On 1.11 and later having this aliasscope causes issues
# even with kernels that don't use `@Const` on arguments
# See https://github.com/JuliaGPU/KernelAbstractions.jl/issues/652
has_constargs && push!(new_stmts, Expr(:aliasscope))
emit_aliasscope = has_constargs && EMIT_ALIASSCOPE
emit_aliasscope && push!(new_stmts, Expr(:aliasscope))
if !unsafe_indices
push!(new_stmts, :(__active_lane__ = $__validindex(__ctx__)))
end
Expand All @@ -109,7 +113,7 @@ function transform_gpu!(def, constargs, force_inbounds, unsafe_indices)
if force_inbounds
push!(new_stmts, Expr(:inbounds, :pop))
end
has_constargs && push!(new_stmts, Expr(:popaliasscope))
emit_aliasscope && push!(new_stmts, Expr(:popaliasscope))
push!(new_stmts, :(return nothing))
def[:body] = Expr(
:let,
Expand Down Expand Up @@ -137,18 +141,16 @@ function transform_cpu!(def, constargs, force_inbounds)
pushfirst!(def[:args], :__ctx__)
new_stmts = Expr[]
body = MacroTools.flatten(def[:body])
# On 1.11 and later having this aliasscope causes issues
# even with kernels that don't use `@Const` on arguments
# See https://github.com/JuliaGPU/KernelAbstractions.jl/issues/652
has_constargs && push!(new_stmts, Expr(:aliasscope))
emit_aliasscope = has_constargs && EMIT_ALIASSCOPE
emit_aliasscope && push!(new_stmts, Expr(:aliasscope))
if force_inbounds
push!(new_stmts, Expr(:inbounds, true))
end
append!(new_stmts, split(emit_cpu, body.args))
if force_inbounds
push!(new_stmts, Expr(:inbounds, :pop))
end
has_constargs && push!(new_stmts, Expr(:popaliasscope))
emit_aliasscope && push!(new_stmts, Expr(:popaliasscope))
push!(new_stmts, :(return nothing))
def[:body] = Expr(
:let,
Expand Down
8 changes: 6 additions & 2 deletions test/test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,12 @@ function unittest_testsuite(Backend, backend_str, backend_mod, BackendArrayT; sk
end
end
if backend_str == "CPU"
@test occursin("!alias.scope", IR)
@test occursin("!noalias", IR)
if KernelAbstractions.EMIT_ALIASSCOPE
@test occursin("!alias.scope", IR)
@test occursin("!noalias", IR)
else
@test_skip false
end
elseif backend_str == "CUDA"
if Base.libllvm_version >= v"20"
@test occursin("addrspace(1)", IR)
Expand Down
Loading