Skip to content

Fix broken AQUA test - #787

Merged
christiangnrd merged 1 commit into
mainfrom
fix
Sep 18, 2026
Merged

Fix broken AQUA test#787
christiangnrd merged 1 commit into
mainfrom
fix

Conversation

@christiangnrd

@christiangnrd christiangnrd commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Broken by I assume AQUA.jl v0.8.17

Also include some NFC Project.toml moving around to save on the hassle of having to revert it every Pkg operation

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

Show table
main 72fcfa9... main / 72fcfa9...
const/@Const/Float32/262144 0.343 ± 0.028 ms 0.341 ± 0.028 ms 1 ± 0.12
const/@Const/Float32/65536 0.127 ± 0.027 ms 0.123 ± 0.027 ms 1.03 ± 0.32
const/@Const/Float64/262144 0.427 ± 0.041 ms 0.419 ± 0.037 ms 1.02 ± 0.13
const/@Const/Float64/65536 0.168 ± 0.013 ms 0.154 ± 0.024 ms 1.09 ± 0.19
const/unmarked/Float32/262144 1.17 ± 0.036 ms 1.17 ± 0.034 ms 1 ± 0.043
const/unmarked/Float32/65536 0.328 ± 0.035 ms 0.324 ± 0.034 ms 1.01 ± 0.15
const/unmarked/Float64/262144 1.34 ± 0.037 ms 1.35 ± 0.037 ms 0.994 ± 0.039
const/unmarked/Float64/65536 0.398 ± 0.032 ms 0.382 ± 0.04 ms 1.04 ± 0.14
launch/3D static workgroup, dynamic ndrange 0.0717 ± 0.027 ms 0.0712 ± 0.025 ms 1.01 ± 0.51
launch/3D static workgroup, static ndrange 0.0721 ± 0.027 ms 0.0718 ± 0.026 ms 1 ± 0.53
launch/dynamic workgroup, dynamic ndrange 0.074 ± 0.027 ms 0.0739 ± 0.024 ms 1 ± 0.49
launch/dynamic workgroup, dynamic ndrange, workgroupsize given 0.0719 ± 0.026 ms 0.0695 ± 0.03 ms 1.03 ± 0.57
launch/static workgroup, dynamic ndrange 0.0704 ± 0.028 ms 0.071 ± 0.027 ms 0.99 ± 0.54
launch/static workgroup, static ndrange 0.0712 ± 0.025 ms 0.071 ± 0.027 ms 1 ± 0.52
partition/dynamic workgroup, dynamic ndrange 0.0586 ± 0.0012 μs 0.0581 ± 0.001 μs 1.01 ± 0.028
partition/static workgroup, dynamic ndrange 0.0653 ± 0.012 μs 0.0668 ± 0.012 μs 0.978 ± 0.25
partition/static workgroup, static ndrange 1.55 ± 0.01 ns 1.55 ± 0.009 ns 1 ± 0.0087
saxpy/default/Float16/1024 0.0781 ± 0.0036 ms 0.0771 ± 0.013 ms 1.01 ± 0.18
saxpy/default/Float16/1048576 0.784 ± 0.029 ms 0.789 ± 0.03 ms 0.993 ± 0.053
saxpy/default/Float16/16384 0.067 ± 0.034 ms 0.0659 ± 0.033 ms 1.02 ± 0.72
saxpy/default/Float16/2048 0.0803 ± 0.02 ms 0.0793 ± 0.023 ms 1.01 ± 0.39
saxpy/default/Float16/256 0.0774 ± 0.0041 ms 0.0757 ± 0.013 ms 1.02 ± 0.18
saxpy/default/Float16/262144 0.243 ± 0.031 ms 0.245 ± 0.032 ms 0.988 ± 0.18
saxpy/default/Float16/32768 0.0754 ± 0.032 ms 0.0738 ± 0.031 ms 1.02 ± 0.6
saxpy/default/Float16/4096 0.0833 ± 0.029 ms 0.0822 ± 0.029 ms 1.01 ± 0.5
saxpy/default/Float16/512 0.0775 ± 0.003 ms 0.076 ± 0.016 ms 1.02 ± 0.21
saxpy/default/Float16/64 0.0773 ± 0.0058 ms 0.0761 ± 0.016 ms 1.02 ± 0.23
saxpy/default/Float16/65536 0.0967 ± 0.029 ms 0.0965 ± 0.028 ms 1 ± 0.42
saxpy/default/Float32/1024 0.0773 ± 0.0025 ms 0.0759 ± 0.015 ms 1.02 ± 0.21
saxpy/default/Float32/1048576 0.496 ± 0.024 ms 0.496 ± 0.024 ms 0.999 ± 0.068
saxpy/default/Float32/16384 0.0585 ± 0.031 ms 0.0584 ± 0.032 ms 1 ± 0.77
saxpy/default/Float32/2048 0.0779 ± 0.022 ms 0.0753 ± 0.028 ms 1.03 ± 0.49
saxpy/default/Float32/256 0.0772 ± 0.0041 ms 0.0757 ± 0.02 ms 1.02 ± 0.27
saxpy/default/Float32/262144 0.172 ± 0.029 ms 0.177 ± 0.03 ms 0.97 ± 0.23
saxpy/default/Float32/32768 0.0652 ± 0.03 ms 0.0644 ± 0.03 ms 1.01 ± 0.66
saxpy/default/Float32/4096 0.0779 ± 0.032 ms 0.0734 ± 0.031 ms 1.06 ± 0.63
saxpy/default/Float32/512 0.0766 ± 0.0033 ms 0.0754 ± 0.016 ms 1.02 ± 0.22
saxpy/default/Float32/64 0.0774 ± 0.0077 ms 0.0759 ± 0.017 ms 1.02 ± 0.25
saxpy/default/Float32/65536 0.0795 ± 0.03 ms 0.0806 ± 0.03 ms 0.987 ± 0.53
saxpy/default/Float64/1024 0.0773 ± 0.004 ms 0.0754 ± 0.024 ms 1.02 ± 0.33
saxpy/default/Float64/1048576 0.572 ± 0.089 ms 0.552 ± 0.051 ms 1.04 ± 0.19
saxpy/default/Float64/16384 0.0588 ± 0.029 ms 0.0578 ± 0.029 ms 1.02 ± 0.72
saxpy/default/Float64/2048 0.0783 ± 0.028 ms 0.0753 ± 0.03 ms 1.04 ± 0.56
saxpy/default/Float64/256 0.077 ± 0.0035 ms 0.0758 ± 0.014 ms 1.02 ± 0.19
saxpy/default/Float64/262144 0.182 ± 0.034 ms 0.184 ± 0.032 ms 0.989 ± 0.25
saxpy/default/Float64/32768 0.0677 ± 0.029 ms 0.0683 ± 0.029 ms 0.991 ± 0.59
saxpy/default/Float64/4096 0.0698 ± 0.029 ms 0.0664 ± 0.029 ms 1.05 ± 0.64
saxpy/default/Float64/512 0.0776 ± 0.0035 ms 0.0754 ± 0.017 ms 1.03 ± 0.24
saxpy/default/Float64/64 0.0777 ± 0.006 ms 0.076 ± 0.019 ms 1.02 ± 0.27
saxpy/default/Float64/65536 0.0863 ± 0.029 ms 0.0878 ± 0.03 ms 0.983 ± 0.48
saxpy/static workgroup=(1024,)/Float16/1024 0.075 ± 0.0044 ms 0.0741 ± 0.021 ms 1.01 ± 0.29
saxpy/static workgroup=(1024,)/Float16/1048576 0.778 ± 0.028 ms 0.783 ± 0.029 ms 0.993 ± 0.051
saxpy/static workgroup=(1024,)/Float16/16384 0.0619 ± 0.032 ms 0.0617 ± 0.032 ms 1 ± 0.74
saxpy/static workgroup=(1024,)/Float16/2048 0.0773 ± 0.023 ms 0.0758 ± 0.026 ms 1.02 ± 0.47
saxpy/static workgroup=(1024,)/Float16/256 0.0744 ± 0.008 ms 0.0733 ± 0.023 ms 1.02 ± 0.33
saxpy/static workgroup=(1024,)/Float16/262144 0.235 ± 0.03 ms 0.239 ± 0.032 ms 0.985 ± 0.18
saxpy/static workgroup=(1024,)/Float16/32768 0.0708 ± 0.03 ms 0.0705 ± 0.03 ms 1 ± 0.6
saxpy/static workgroup=(1024,)/Float16/4096 0.0794 ± 0.031 ms 0.0779 ± 0.032 ms 1.02 ± 0.58
saxpy/static workgroup=(1024,)/Float16/512 0.0748 ± 0.0057 ms 0.0734 ± 0.018 ms 1.02 ± 0.26
saxpy/static workgroup=(1024,)/Float16/64 0.0743 ± 0.014 ms 0.0728 ± 0.023 ms 1.02 ± 0.37
saxpy/static workgroup=(1024,)/Float16/65536 0.0924 ± 0.026 ms 0.0925 ± 0.027 ms 0.999 ± 0.4
saxpy/static workgroup=(1024,)/Float32/1024 0.0745 ± 0.0037 ms 0.0726 ± 0.018 ms 1.03 ± 0.26
saxpy/static workgroup=(1024,)/Float32/1048576 0.49 ± 0.022 ms 0.497 ± 0.025 ms 0.985 ± 0.067
saxpy/static workgroup=(1024,)/Float32/16384 0.0549 ± 0.029 ms 0.0557 ± 0.03 ms 0.986 ± 0.75
saxpy/static workgroup=(1024,)/Float32/2048 0.0746 ± 0.026 ms 0.0699 ± 0.029 ms 1.07 ± 0.57
saxpy/static workgroup=(1024,)/Float32/256 0.0744 ± 0.0082 ms 0.0728 ± 0.02 ms 1.02 ± 0.3
saxpy/static workgroup=(1024,)/Float32/262144 0.167 ± 0.028 ms 0.171 ± 0.029 ms 0.972 ± 0.23
saxpy/static workgroup=(1024,)/Float32/32768 0.0605 ± 0.027 ms 0.0611 ± 0.028 ms 0.989 ± 0.63
saxpy/static workgroup=(1024,)/Float32/4096 0.073 ± 0.033 ms 0.0737 ± 0.033 ms 0.991 ± 0.63
saxpy/static workgroup=(1024,)/Float32/512 0.0742 ± 0.0057 ms 0.0729 ± 0.019 ms 1.02 ± 0.28
saxpy/static workgroup=(1024,)/Float32/64 0.0745 ± 0.013 ms 0.0729 ± 0.022 ms 1.02 ± 0.36
saxpy/static workgroup=(1024,)/Float32/65536 0.076 ± 0.028 ms 0.0766 ± 0.03 ms 0.992 ± 0.53
saxpy/static workgroup=(1024,)/Float64/1024 0.074 ± 0.0068 ms 0.0726 ± 0.023 ms 1.02 ± 0.34
saxpy/static workgroup=(1024,)/Float64/1048576 0.573 ± 0.089 ms 0.551 ± 0.046 ms 1.04 ± 0.18
saxpy/static workgroup=(1024,)/Float64/16384 0.0561 ± 0.028 ms 0.0554 ± 0.028 ms 1.01 ± 0.72
saxpy/static workgroup=(1024,)/Float64/2048 0.0751 ± 0.027 ms 0.0718 ± 0.03 ms 1.05 ± 0.58
saxpy/static workgroup=(1024,)/Float64/256 0.0742 ± 0.013 ms 0.0732 ± 0.022 ms 1.01 ± 0.35
saxpy/static workgroup=(1024,)/Float64/262144 0.18 ± 0.035 ms 0.184 ± 0.033 ms 0.981 ± 0.26
saxpy/static workgroup=(1024,)/Float64/32768 0.0648 ± 0.027 ms 0.0644 ± 0.028 ms 1.01 ± 0.61
saxpy/static workgroup=(1024,)/Float64/4096 0.0664 ± 0.031 ms 0.0623 ± 0.03 ms 1.07 ± 0.71
saxpy/static workgroup=(1024,)/Float64/512 0.0745 ± 0.0054 ms 0.0728 ± 0.021 ms 1.02 ± 0.31
saxpy/static workgroup=(1024,)/Float64/64 0.0745 ± 0.014 ms 0.0726 ± 0.022 ms 1.03 ± 0.37
saxpy/static workgroup=(1024,)/Float64/65536 0.0816 ± 0.029 ms 0.0862 ± 0.03 ms 0.947 ± 0.47
time_to_load 0.794 ± 0.024 s 0.838 ± 0.014 s 0.947 ± 0.033
main 72fcfa9... main / 72fcfa9...
const/@Const/Float32/262144 1 allocs: 16 B 1 allocs: 16 B 1
const/@Const/Float32/65536 1 allocs: 16 B 1 allocs: 16 B 1
const/@Const/Float64/262144 1 allocs: 16 B 1 allocs: 16 B 1
const/@Const/Float64/65536 1 allocs: 16 B 1 allocs: 16 B 1
const/unmarked/Float32/262144 1 allocs: 16 B 1 allocs: 16 B 1
const/unmarked/Float32/65536 1 allocs: 16 B 1 allocs: 16 B 1
const/unmarked/Float64/262144 1 allocs: 16 B 1 allocs: 16 B 1
const/unmarked/Float64/65536 1 allocs: 16 B 1 allocs: 16 B 1
launch/3D static workgroup, dynamic ndrange 5 allocs: 0.141 kB 5 allocs: 0.141 kB 1
launch/3D static workgroup, static ndrange 6 allocs: 0.172 kB 6 allocs: 0.172 kB 1
launch/dynamic workgroup, dynamic ndrange 15 allocs: 0.312 kB 15 allocs: 0.312 kB 1
launch/dynamic workgroup, dynamic ndrange, workgroupsize given 1 allocs: 16 B 1 allocs: 16 B 1
launch/static workgroup, dynamic ndrange 1 allocs: 16 B 1 allocs: 16 B 1
launch/static workgroup, static ndrange 2 allocs: 0.0469 kB 2 allocs: 0.0469 kB 1
partition/dynamic workgroup, dynamic ndrange 2 allocs: 0.0625 kB 2 allocs: 0.0625 kB 1
partition/static workgroup, dynamic ndrange 2 allocs: 32 B 2 allocs: 32 B 1
partition/static workgroup, static ndrange 0 allocs: 0 B 0 allocs: 0 B
saxpy/default/Float16/1024 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float16/1048576 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float16/16384 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float16/2048 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float16/256 16 allocs: 0.328 kB 16 allocs: 0.328 kB 1
saxpy/default/Float16/262144 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float16/32768 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float16/4096 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float16/512 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float16/64 16 allocs: 0.328 kB 16 allocs: 0.328 kB 1
saxpy/default/Float16/65536 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float32/1024 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float32/1048576 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float32/16384 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float32/2048 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float32/256 16 allocs: 0.328 kB 16 allocs: 0.328 kB 1
saxpy/default/Float32/262144 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float32/32768 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float32/4096 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float32/512 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float32/64 16 allocs: 0.328 kB 16 allocs: 0.328 kB 1
saxpy/default/Float32/65536 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float64/1024 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float64/1048576 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float64/16384 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float64/2048 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float64/256 16 allocs: 0.328 kB 16 allocs: 0.328 kB 1
saxpy/default/Float64/262144 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float64/32768 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float64/4096 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float64/512 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/default/Float64/64 16 allocs: 0.328 kB 16 allocs: 0.328 kB 1
saxpy/default/Float64/65536 24 allocs: 0.453 kB 24 allocs: 0.453 kB 1
saxpy/static workgroup=(1024,)/Float16/1024 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float16/1048576 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float16/16384 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float16/2048 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float16/256 1 allocs: 16 B 1 allocs: 16 B 1
saxpy/static workgroup=(1024,)/Float16/262144 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float16/32768 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float16/4096 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float16/512 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float16/64 1 allocs: 16 B 1 allocs: 16 B 1
saxpy/static workgroup=(1024,)/Float16/65536 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float32/1024 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float32/1048576 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float32/16384 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float32/2048 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float32/256 1 allocs: 16 B 1 allocs: 16 B 1
saxpy/static workgroup=(1024,)/Float32/262144 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float32/32768 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float32/4096 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float32/512 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float32/64 1 allocs: 16 B 1 allocs: 16 B 1
saxpy/static workgroup=(1024,)/Float32/65536 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float64/1024 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float64/1048576 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float64/16384 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float64/2048 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float64/256 1 allocs: 16 B 1 allocs: 16 B 1
saxpy/static workgroup=(1024,)/Float64/262144 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float64/32768 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float64/4096 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float64/512 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
saxpy/static workgroup=(1024,)/Float64/64 1 allocs: 16 B 1 allocs: 16 B 1
saxpy/static workgroup=(1024,)/Float64/65536 4 allocs: 0.0625 kB 4 allocs: 0.0625 kB 1
time_to_load 0.201 k allocs: 11.8 kB 0.201 k allocs: 11.8 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@christiangnrd

christiangnrd commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

@vchuravy I'm going to merge this to get CI green again and we can address the issue (if necessary) in a follow-up PR

@christiangnrd
christiangnrd merged commit ec76083 into main Sep 18, 2026
73 of 78 checks passed
@christiangnrd
christiangnrd deleted the fix branch September 18, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@christiangnrd