[release-0.9] Rebuild reshaped and permuted arrays without validation in @Const - #794
Merged
Merged
Conversation
Adapt.jl's rules for ReshapedArray and PermutedDimsArray go through constructors whose error paths build strings, which fails to compile when `constify` runs inside a GPU kernel. Reuse the existing fields instead, as adapting only replaces the parent array. Fixes #792
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-0.9 #794 +/- ##
===============================================
+ Coverage 79.38% 79.69% +0.31%
===============================================
Files 14 14
Lines 907 911 +4
===============================================
+ Hits 720 726 +6
+ Misses 187 185 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #793 to 0.9, which CUDA.jl and the other back-ends currently use. The testset on this branch had no
constarg2dkernel, so that is added along with the test.@Constadapts its argument inside the kernel, and Adapt.jl's rules forReshapedArray(viareshape, which recomputes theSignedMultiplicativeInverses) andPermutedDimsArray(whose constructor checksisperm_inverse) go through error paths that build strings, which fails to compile on GPU back-ends. This addsConstAdaptor-specific rules that swap in the constified parent and reuse the existing fields, which also avoids recomputing the inverses in every thread. The rules are specific toConstAdaptorbecause host-sideadaptrelies onreshapecollapsing wrappers into plain arrays.Fixes #792