Report all toolchain JLLs and their overrides in versioninfo - #507
Merged
Merged
Conversation
List SPIRV_Tools_jll and spirv2clc_jll next to the other JLLs the compiler uses, and for every JLL shown (including pocl_jll) say when its products don't come from the registered artifact: either because a `<product>_path` preference points elsewhere, or because an `Overrides.toml` entry replaces the artifact. This makes it visible in test logs when, e.g., a locally built PoCL or spirv2clc is being used.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
+ Coverage 83.23% 83.34% +0.10%
==========================================
Files 19 19
Lines 1587 1603 +16
==========================================
+ Hits 1321 1336 +15
- Misses 266 267 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCL.versioninfo()now also listsSPIRV_Tools_jllandspirv2clc_jll, and says when a JLL's products don't come from the registered artifact. That covers both override mechanisms: a<product>_pathpreference (e.g.libpocl_path, which this repo's CI uses to test PoCL HEAD) and anOverrides.tomlentry for the artifact. This makes the test logs (runtests.jlprintsversioninfo) show which binaries were actually used.I need this for spirv2clc's CI (JuliaGPU/spirv2clc#2), which runs this package's
poclc/tests withspirv2clc_jllpointed at the binary under test. Example local output, with aspirv2clc_pathpreference on top of anOverrides.tomlentry, and alibpocl_pathpreference:Without overrides the output is unchanged apart from the two added JLLs.