Skip to content

Inverse plans (inv, \, ldiv!) and in-place plans (plan_fft!, plan_bfft!) #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pankgeorg wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Inverse plans (inv, \, ldiv!) and in-place plans (plan_fft!, plan_bfft!) #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f58ee0
Fix method ambiguity with FFTW.jl for plan_rfft/plan_brfft
pankgeorg Aug 29, 2026
c9d0a99
Real plans: mul!, allocation-free execution, dims path, real 2D path
pankgeorg Aug 29, 2026
2d9697a
Inverse plans (inv, \, ldiv!) and in-place plans (plan_fft!, plan_bfft!)
pankgeorg Aug 29, 2026
a153e0c
test: only require allocation-free in-place execution for 1D plans; a…
pankgeorg Aug 29, 2026
a0d37e6
test: treat plan_fft!/plan_bfft! as own in the Aqua piracy check, lik…
pankgeorg Aug 29, 2026
600d633
Real plans: copy strided pencils to contiguous buffers before the ker…
pankgeorg Aug 29, 2026
5fae53d
Merge feat/real-plan-mul (strided pencil copy-in) into feat/inverse-i…
pankgeorg Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ AbstractFFTs = "1"
Aqua = "0.8"
DocStringExtensions = "0.9"
ExplicitImports = "1.12"
FFTW = "1.8"
LinearAlgebra = "<0.0.1, 1"
MuladdMacro = "0.2"
Primes = "0.5"
Expand All @@ -28,7 +29,8 @@ julia = "1.6.7"
[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
FFTW = "7a1cc6ca-52ef-59f5-83cd-3a7055c09341"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Aqua", "ExplicitImports", "Test"]
test = ["Aqua", "ExplicitImports", "FFTW", "Test"]
2 changes: 1 addition & 1 deletion docs/src/dev.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Here is the documentation for key parts of the development side of the package.
CallGraphNode
CallGraph
CallGraphNode!
fft!
fft_kernel!
fft_dft!
fft_pow3!
```
6 changes: 3 additions & 3 deletions src/algos.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Int(d)
end

function fft!(
function fft_kernel!(
out::AbstractVector{T}, in::AbstractVector{<:Number},
start_out::Int, start_in::Int,
d::Direction,
Expand Down Expand Up @@ -85,7 +85,7 @@ function fft_composite!(
R_s_out = right.s_out
fft_bluestein!(tmp, in, d, N2, R_start_out, R_s_out, R_start_in, R_s_in, R_bluestein_scratchspace)
else
fft!(tmp, in, R_start_out, R_start_in, d, Rt, g, right_idx)
fft_kernel!(tmp, in, R_start_out, R_start_in, d, Rt, g, right_idx)
end

if j1 > 0
Expand All @@ -112,7 +112,7 @@ function fft_composite!(
L_s_out = left.s_out
fft_bluestein!(out, tmp, d, N1, L_start_out, L_s_out, L_start_in, L_s_in, L_bluestein_scratchspace)
else
fft!(out, tmp, L_start_out, L_start_in, d, Lt, g, left_idx)
fft_kernel!(out, tmp, L_start_out, L_start_in, d, Lt, g, left_idx)
end
end
end
Expand Down
Loading
Loading