Conversation
|
I am closing because it worked locally on my machine, but it looks like it hangs and hangs on the CI, i do not want to consume 10* 6h of CI for JuliaMath and cannot stop teh Ci myself. |
|
Closing a PR doesn't cancel CI jobs (that's just how GitHub Actions works). Perhaps it'd be a good start to open a PR to set a reasonable timeout these workflows |
|
Did not know that, thanks. I added a temporary timeout to the workflows. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 14 14
Lines 3023 3023
=======================================
Hits 2862 2862
Misses 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I opened #559 with a different fix based on my understanding of the issue. |
|
I knew someone will know more than me ;) Thanks @devmotion |
Fixes #557
It took me few attempts but i managed to do it. I do not know why this tol was set as
eps(2abs(x)), and whether my proposal is sound, but at least it solves the issue.