Faster rankUpdate! method for HermitianRFP - #910
Conversation
|
We now have the peculiar situation that the Should we always sort the levels of the second grouping factor when |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #910 +/- ##
==========================================
- Coverage 95.69% 94.92% -0.77%
==========================================
Files 38 38
Lines 3760 3921 +161
==========================================
+ Hits 3598 3722 +124
- Misses 162 199 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rankUpdate!(C::HermitianRFP{T}, A::SparseMatrixCSC{T}, ...)method to useA.colptrdirectly and avoid calls tonzrange(A, j)which just add another layer of indirection.C.datawhere linear indexing can be used.