Skip to content

fix forwarding of beta kwarg in quantile!(::AbstractArray...)#205

Merged
nalimilan merged 2 commits into
JuliaStats:masterfrom
MasonProtter:mp/fix-beta-kwarg
May 15, 2026
Merged

fix forwarding of beta kwarg in quantile!(::AbstractArray...)#205
nalimilan merged 2 commits into
JuliaStats:masterfrom
MasonProtter:mp/fix-beta-kwarg

Conversation

@MasonProtter

Copy link
Copy Markdown
Contributor

Closes #204

Before:

julia> quantile!(reshape([1.,2,3,4,5],5,1), [.25,.5,.75]; alpha=0, beta=1)  quantile!([1.,2,3,4,5], [.25,.5,.75]; alpha=0, beta=1)
false

after

julia> quantile!(reshape([1.,2,3,4,5],5,1), [.25,.5,.75]; alpha=0, beta=1)  quantile!([1.,2,3,4,5], [.25,.5,.75]; alpha=0, beta=1)
true

@codecov-commenter

codecov-commenter commented May 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.43%. Comparing base (ad4a0cd) to head (67f838b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files           2        2           
  Lines         449      449           
=======================================
  Hits          433      433           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DilumAluthge

Copy link
Copy Markdown
Member

@andreasnoack or @nalimilan - could you review this?

Comment thread test/runtests.jl

@nalimilan nalimilan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops. Thanks!

@nalimilan nalimilan merged commit e14c8f8 into JuliaStats:master May 15, 2026
13 checks passed
@MasonProtter MasonProtter deleted the mp/fix-beta-kwarg branch May 15, 2026 08:17
@MasonProtter

Copy link
Copy Markdown
Contributor Author

What is needed in order to have this bugfix backported for previous julia versions?

@DilumAluthge

Copy link
Copy Markdown
Member

On mobile, but some quick notes:

  1. For each Julia version of interest, go to the JuliaLang/julia repo and go to the relevant backports-release-* branch. If the backports branch doesn't exist, go to release-*. Go to stdlib/Statistics.version and write down the commit sha.
  2. Come to this repo (the Statistics.jl repo). For each Julia version of interest, create a release-* branch off of the correct commit sha (which was determined in the previous step). Some of the release branches might exist already.
  3. In this repo, create backports-release-* off of the top of release-*.
  4. In this repo, cherry-pick the desired commits into backports-release-*. E.g. for this PR, the commit to cherry-pick is e14c8f8. Please include the -x flag when cherry-picking.
  5. In this repo, make a PR to merge backports-release-* into release-*. Get that PR approved and merged.
  6. In the JuliaLang/julia repo, on the backports-release-* branch, edit stdlib/Statistics.version so that the specified branch is release-* (not master).
  7. Trigger BumpStdlibs.jl on the backports-release-* branch in the Julia repo.
  8. Wait for the backports PR in the Julia repo to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quantile!(::AbstractArray) ignores beta kwarg

4 participants