Allow computing the correlation matrix from the covariance matrix only#75
Open
ASaragga wants to merge 1 commit into
Open
Allow computing the correlation matrix from the covariance matrix only#75ASaragga wants to merge 1 commit into
ASaragga wants to merge 1 commit into
Conversation
…y (StatsBase.jl #652)
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 387 455 +68
======================================
- Misses 387 455 +68
Continue to review full report at Codecov.
|
Member
|
Thanks. Can you add a test? Otherwise the function might break at any time without anybody noticing. |
Author
|
Certainly. Already tried the obvious
@test cov2cor(cov1) ≈ cor1
@test cov2cor(cov2) ≈ cor2
but it throws an error...
… On 19 Feb 2021, at 09:01, Milan Bouchet-Valat ***@***.***> wrote:
Thanks. Can you add a test? Otherwise the function might break at any time without anybody noticing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <https://github.com/JuliaLang/Statistics.jl/pull/75#issuecomment-781935829>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALJ5RCBLRR3M5YZ4XZDIBEDS7YSGDANCNFSM4XWX3GUQ>.
|
Member
|
What kind of error? |
Author
|
The cov2cor test errors because it is not considering the method cov2cor!(::Array{Float64,2}) that was added to Statistics.jl. Sorry about this.
The error is
cov2cor: Error During Test at /home/runner/work/StatsBase.jl/StatsBase.jl/test/cov.jl:127
143
<https://github.com/JuliaStats/StatsBase.jl/pull/662/checks?check_run_id=1942164575#step:6:143> Test threw exception
144
<https://github.com/JuliaStats/StatsBase.jl/pull/662/checks?check_run_id=1942164575#step:6:144> Expression: cov2cor(cov1) ≈ cor1
145
<https://github.com/JuliaStats/StatsBase.jl/pull/662/checks?check_run_id=1942164575#step:6:145> MethodError: no method matching cov2cor!(::Array{Float64,2})
… On 19 Feb 2021, at 14:46, Milan Bouchet-Valat ***@***.***> wrote:
What kind of error?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <https://github.com/JuliaLang/Statistics.jl/pull/75#issuecomment-782119403>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALJ5RCAD53UUZJJCLELT52DS7Z2S7ANCNFSM4XWX3GUQ>.
|
Member
|
Well we're in Statistics.jl here, not in StatsBase. :-/ |
Author
|
Indeed! Tests for the family of cov2cor methods in Statistics.jl appear to be missing?! Tried to follow some examples to keep the same style of tests.
Sorry it is taking so long...
… On 20 Feb 2021, at 14:47, Milan Bouchet-Valat ***@***.***> wrote:
Well we're in Statistics.jl here, not in StatsBase. :-/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <https://github.com/JuliaLang/Statistics.jl/pull/75#issuecomment-782692657>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALJ5RCDLDOBNOQUCGYWTDZ3S77DO7ANCNFSM4XWX3GUQ>.
|
Member
|
These are only internal functions in Statistics, so they are only tested indirectly via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussions concerning issue JuliaStats/StatsBase.jl#652.