Fix bugs, typos, and improve DataFrame efficiency - #5
Merged
Conversation
- Fix len(dataframe) bug in reduceShearDataForCell (should be len(reduced)) - Fix duplicate n_uniques assignment and dead x_cents/y_cents overwrites in output_tables - Rename _emtpyCountsMaps -> _emptyCountsMaps - Fix g_2 docstring saying "g1 component" - Fix typos: statisitics, postion, sourcrs, measurment, Attritubes, outout - Add .copy() in wcs_match to avoid SettingWithCopyWarning - Fix input mutation in makeMatchedShearSourceCatalogs - Make ns processing explicit to avoid fragile ordering dependency - shearReport now returns ShearData for programmatic use - Use numpy arrays instead of Series for arithmetic in reduceShearDataForCell and shearStats - Filter early in splitByTypeAndClean to avoid computing columns on discarded rows - Replace merge-on-synthetic-idx with pandas.concat for row-aligned tables - Eliminate redundant DataFrame copy in reduceShearDataForCell Generated with AI Co-Authored-By: SLAC AI
Coverage improvements: - shear_utils: 73% → 100% - shear_data: 80% → 96% - Overall: 92% → 96% All tests use synthetic data with no external dependencies. Generated with AI Co-Authored-By: SLAC AI
eacharles
force-pushed
the
eac/fixes-and-efficiency
branch
from
June 27, 2026 00:15
53e8b4c to
d866891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated with AI
Co-Authored-By: SLAC AI