Fix circular KSM import#2115
Merged
craiglurey merged 2 commits intoJun 3, 2026
Merged
Conversation
Moved KSM, gateway_helper and router_helper into their respective functions to avoid an issue with circular imports when importing commands, eg: `from keepercommander.commands.utils import WhoamiCommand` `from keepercommander.commands.discoveryrotation import PAMGatewayListCommand`
KSMCommand import in pam.gateway_helper doesn't point to the core file where KSMCommand is defined. While this doesn't appear to cause an issue, fixed to avoid any future circular import problems.
idimov-keeper
approved these changes
Jun 3, 2026
sk-keeper
pushed a commit
that referenced
this pull request
Jun 5, 2026
* Fix circular KSM import Moved KSM, gateway_helper and router_helper into their respective functions to avoid an issue with circular imports when importing commands, eg: `from keepercommander.commands.utils import WhoamiCommand` `from keepercommander.commands.discoveryrotation import PAMGatewayListCommand` * Changed KSM import in pam.gateway_helper KSMCommand import in pam.gateway_helper doesn't point to the core file where KSMCommand is defined. While this doesn't appear to cause an issue, fixed to avoid any future circular import problems.
jpkeepersecurity
pushed a commit
that referenced
this pull request
Jun 9, 2026
* Fix circular KSM import Moved KSM, gateway_helper and router_helper into their respective functions to avoid an issue with circular imports when importing commands, eg: `from keepercommander.commands.utils import WhoamiCommand` `from keepercommander.commands.discoveryrotation import PAMGatewayListCommand` * Changed KSM import in pam.gateway_helper KSMCommand import in pam.gateway_helper doesn't point to the core file where KSMCommand is defined. While this doesn't appear to cause an issue, fixed to avoid any future circular import problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved KSM, gateway_helper and router_helper into their respective functions to avoid an issue with circular imports when importing commands, eg:
from keepercommander.commands.utils import WhoamiCommandfrom keepercommander.commands.discoveryrotation import PAMGatewayListCommand