Skip to content

KC-1307, KC-1308, KC-1309 & KC-1310: Fix: nsf share expiration updates, rename Supershell Drive folder labels, and standardize list command's record_category#2138

Open
sshrushanth-ks wants to merge 4 commits into
nsf-share-command-fixfrom
nsf-share-command-fix-int
Open

KC-1307, KC-1308, KC-1309 & KC-1310: Fix: nsf share expiration updates, rename Supershell Drive folder labels, and standardize list command's record_category#2138
sshrushanth-ks wants to merge 4 commits into
nsf-share-command-fixfrom
nsf-share-command-fix-int

Conversation

@sshrushanth-ks

Copy link
Copy Markdown
Contributor

Summary

Fixed expiration updates for nsf-share-folder and nsf-share-record, enforced a one-minute minimum on NSF and classic share commands, standardized list/search record_category to classic/nested, and renamed Supershell Drive folder labels to Nested Shared Folder (Shared) and (NonShared).

Changes

  • Fixed nsf-share-folder not updating expiration on existing shares by adding expiration_timestamp to update_folder_access_v3 and passing it through from grant_folder_access_v3
  • Fixed already_had_access and never (-1) handling so same-role expiration updates and clear-expiration requests worked correctly
  • Fixed nsf-share-record expiration updates by revoking and re-granting sequentially, since the server only inserts expiration rows on create
  • Reduced redundant syncs during record share updates, added revoke/re-grant progress logging, and skipped no-op updates when role and expiration already matched
  • Fixed reading tla_expiration from access details after an invalid proto3 HasField check caused existing shares to be treated as new grants
  • Enforced a one-minute minimum share expiration on nsf-share-record, nsf-share-folder, share-record, and share-folder
  • Added unit tests for folder/record expiration updates, sub-minute rejection, revoke-and-recreate, and access-detail parsing
  • Standardized list/search record_category from Classic/Nested to lowercase classic/nested
  • Renamed Supershell folder icon labels to Nested Shared Folder (Shared) and Nested Shared Folder (NonShared)

sshrushanth-ks and others added 4 commits June 10, 2026 11:44
Revoke and re-grant record shares when changing expiration because the
server only inserts expiration rows on create. Skip redundant updates,
reduce sync overhead, and apply the same minimum expiration validation
to classic share-record and share-folder.

Co-authored-by: Cursor <cursoragent@cursor.com>
@sshrushanth-ks sshrushanth-ks marked this pull request as ready for review June 11, 2026 10:28
@sshrushanth-ks sshrushanth-ks self-assigned this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant