KC-1307, KC-1308, KC-1309 & KC-1310: Fix: nsf share expiration updates, rename Supershell Drive folder labels, and standardize list command's record_category#2138
Open
sshrushanth-ks wants to merge 4 commits into
Conversation
…_category to classic/nested
Revoke and re-grant record shares when changing expiration because the server only inserts expiration rows on create. Skip redundant updates, reduce sync overhead, and apply the same minimum expiration validation to classic share-record and share-folder. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed expiration updates for nsf-share-folder and nsf-share-record, enforced a one-minute minimum on NSF and classic share commands, standardized list/search record_category to classic/nested, and renamed Supershell Drive folder labels to Nested Shared Folder (Shared) and (NonShared).
Changes