Fix incorrect struct initialization in khr_locate_spaces sample code - #200
Merged
rpavlik merged 2 commits intoJul 15, 2026
Merged
Conversation
|
|
Collaborator
|
An issue (number 2777) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2777 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
rpavlik-bot
added
the
synced to gitlab
|
Thanks for the fix. LGTM |
Contributor
|
Can you change this so it merges into staging? (And add a changelog fragment?) |
rpavlik
approved these changes
Jul 15, 2026
Contributor
Author
|
No problem, update it now. |
XrSpaceLocationsKHR was initialized with XR_TYPE_SPACES_LOCATE_INFO_KHR (the locate-info struct's type token) instead of XR_TYPE_SPACE_LOCATIONS_KHR, so the sample as written is rejected by a conformant runtime. The core-spec version of the same sample in spaces.adoc already uses the correct token. Also update the extension's last modified date.
utzcoz
force-pushed
the
fix-incorrect-struct-initialization
branch
from
July 15, 2026 14:45
014173f to
297f2d6
Compare
Contributor
Author
|
@rpavlik Updated. PTAL. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XrSpaceLocationsKHR was initialized with XR_TYPE_SPACES_LOCATE_INFO_KHR (the locate-info struct's type token) instead of
XR_TYPE_SPACE_LOCATIONS_KHR, so the sample as written is rejected by a conformant runtime. The core-spec version of the same sample in spaces.adoc already uses the correct token.
Also update the extension's last modified date.