profiles: Dev dependencies#915
Open
christophe-lunarg wants to merge 15 commits into
Open
Conversation
The Vulkan-Profiles build requires unusual Python modules jsonschema and pyinstaller to be installed in whatever Python is used to build the standalone executables. Rather than rely on the system Python including these modules, this code change causes the build to create its on Python virtual environment, and install the necessary Python modules in the virtual environment, before using it to build the executables. CMakeLists.txt: - require Python 3.10, to insure pyinstaller 6 can be installed - create a Python virtual environment using requirements.txt - use the Python virtual environment to make FINAL_EXECUTABLE requirements.txt: new file - include all the Python modules that aren't part of the Python Standard Library
The Python script needs to access the Vulkan-Headers version of vulkan_object.py. It doesn't need the vulkan_object module.
Or they end up complaining about missing "pyparsing" modules We also need a python_venv dependency so a subdirectory can reference it
christophe-lunarg
added
enhancement
Collaborator
|
CI VulkanProfiles build queued with queue ID 49562. |
1 similar comment
Collaborator
|
CI VulkanProfiles build queued with queue ID 49562. |
Collaborator
|
CI VulkanProfiles build # 4026 running. |
Collaborator
|
CI VulkanProfiles build # 4026 failed. |
christophe-lunarg
changed the title
Collaborator
|
CI VulkanProfiles build queued with queue ID 49814. |
Collaborator
|
CI VulkanProfiles build # 4036 running. |
Collaborator
|
CI VulkanProfiles build # 4036 passed. |
Collaborator
|
CI VulkanProfiles build queued with queue ID 50787. |
Collaborator
|
CI VulkanProfiles build queued with queue ID 50799. |
Collaborator
|
CI VulkanProfiles build # 4047 running. |
Collaborator
|
CI VulkanProfiles build # 4047 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vkprofilesstandalone executable to replace python scripts