build: Update required CMake version to 3.28.3#393
Open
charles-lunarg wants to merge 5 commits into
Open
Conversation
ziga-lunarg
approved these changes
Jul 15, 2026
spencer-lunarg
approved these changes
Jul 15, 2026
charles-lunarg
force-pushed
the
update_cmake_version
branch
from
July 15, 2026 16:29
190a53d to
2152393
Compare
Collaborator
Author
|
Note - this will wait until after the 1.4.357 Header update. As well as an audit of the CI machines to ensure that they all are on CMake 3.28. |
Prevents ci failures due to clang-format version differences in vk_safe_struct_utils.cpp.
This fixes a maybe-uninitialized warning flagged by GCC 15.2 inside of the initialize() function called by union constructors. The commit also refactors safe_struct_generators.py to be more python by collecting the struct/ union member initializers into a list then calling ','.join() to create a comma delimited string.
charles-lunarg
force-pushed
the
update_cmake_version
branch
from
July 15, 2026 20:05
2152393 to
2f94be6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.