Skip to content

Open test measurements panel by default #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williamjallen merged 1 commit into from
Sep 25, 2026
+1 −2
Merged

Open test measurements panel by default #4007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions resources/js/vue/components/TestIdPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@
</details>
<details
v-if="allMeasurements.length > 0"
open
class="tw-collapse tw-collapse-plus tw-join-item tw-border tw-border-base-300"
data-test="measurements-collapse"
>
Expand Down
2 changes: 0 additions & 2 deletions tests/Browser/Pages/TestsIdPageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ public function testEnvironmentExcludedFromMeasurements(): void
$this->browse(function (Browser $browser) use ($test, $otherMeasurement): void {
$browser->visit("/tests/{$test->id}")
->waitFor('@measurements-collapse')
->click('@measurements-collapse')
->waitForText($otherMeasurement->value)
->assertSee($otherMeasurement->name)
->within('@measurements-collapse', function (Browser $browser): void {
Expand Down Expand Up @@ -264,7 +263,6 @@ public function testMeasurementTypes(string $type, string $value): void
$this->browse(function (Browser $browser) use ($test, $measurement, $type): void {
$browser->visit("/tests/{$test->id}")
->waitFor('@measurements-collapse')
->click('@measurements-collapse')
->waitForText($measurement->name);

$browser->assertSee($measurement->name);
Expand Down
Loading