Skip to content

Keep the pixel data when capturing a frame from an image element #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryonLewis merged 1 commit into from
Sep 25, 2026
Merged

Keep the pixel data when capturing a frame from an image element #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/dive-common/use/stereo/frameSource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ export function imageElementToRgba(
const ctx = canvas.getContext('2d');
if (!ctx) throw new Error('Could not get 2d canvas context');
ctx.drawImage(img as CanvasImageSource, 0, 0, width, height);
return { ...ctx.getImageData(0, 0, width, height), width, height };
// ImageData's fields are prototype getters, which a spread would drop.
const { data } = ctx.getImageData(0, 0, width, height);
return { data, width, height };
}

/**
Expand Down
Loading