Always clear the companion box layer once it has nothing to show - #1981
Merged
Merged
Conversation
GeoJS ends editing on its own (right-click, completion) and leaves the box behind in disabled mode; skipping disable() there kept it as a ghost on every frame with a hover highlight.
BryonLewis
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boxEditLayer.disable()whenever the companion was already in disabled mode, to avoid a redundantmode(null). GeoJS puts the layer in that mode itself when editing ends (right-click, completion) while keeping the completed box, so the box survived as a ghost on every frame, with GeoJS's hover highlight on it even when nothing was selecteddisable()clear overlays without the redundantmode(null), so calling it unconditionally is now safe; this removes the remaining bypass🤖 Generated with Claude Code