Fix paired stereo review in the web interface - #1984
Merged
Merged
Conversation
BryonLewis
self-requested a review
September 25, 2026 16:55
BryonLewis
approved these changes
Sep 25, 2026
BryonLewis
left a comment
Collaborator
There was a problem hiding this comment.
Tested and allows adding multicamera datasets for review on web. Added a small change to prevent sub-cameras from being added as their own dataset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web review can load an individual stereo camera as a standalone dataset, showing one side per entry. The web dataset picker also excluded multicamera parents because it reused scoring restrictions.
Resolve camera-folder selections and camera viewer links to the stereo parent before loading review. Selecting either camera, both cameras, or the parent now loads one sequence with paired views for matching track IDs. Review-specific listing and picker hooks allow whole rigs. Internal camera IDs remain separate for media, annotations, and saves.
Load the parent hierarchy and shared type styles for camera review configs, and honor cameraOrder without dropping cameras from incomplete legacy lists. Both platforms use the shared review controls for synchronized frames and zoom/pan, linked classification/acceptance/deletion, and camera-specific geometry edits.
Validation:
No live deployed stereo dataset was available for a browser walkthrough. Integration tests use real web adapters with mocked Girder responses and media decoding.