Skip to content

Fix paired stereo review in the web interface - #1984

Merged
BryonLewis merged 3 commits into
mainfrom
fix/web-stereo-review
Sep 25, 2026
Merged

BryonLewis merged 3 commits into
mainfrom
fix/web-stereo-review

Conversation

@mattdawkins

@mattdawkins mattdawkins commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Web review can load an individual stereo camera as a standalone dataset, showing one side per entry. The web dataset picker also excluded multicamera parents because it reused scoring restrictions.

Resolve camera-folder selections and camera viewer links to the stereo parent before loading review. Selecting either camera, both cameras, or the parent now loads one sequence with paired views for matching track IDs. Review-specific listing and picker hooks allow whole rigs. Internal camera IDs remain separate for media, annotations, and saves.

Load the parent hierarchy and shared type styles for camera review configs, and honor cameraOrder without dropping cameras from incomplete legacy lists. Both platforms use the shared review controls for synchronized frames and zoom/pan, linked classification/acceptance/deletion, and camera-specific geometry edits.

Validation:

  • 202 tests passed across web-girder and shared review services, components, and helpers.
  • Regression cases include starting from either raw camera folder or composite camera link, duplicate parent/camera selections, deferred loading, standalone datasets, sparse frames, hierarchy-aware edits, camera-specific saves, retry, and denied camera access.
  • ESLint and TypeScript checks passed.
  • Web production build passed; desktop production build passed during the initial PR validation.

No live deployed stereo dataset was available for a browser walkthrough. Integration tests use real web adapters with mocked Girder responses and media decoding.

@mattdawkins mattdawkins changed the title Fix web stereo review selection and camera configuration Fix paired stereo review in the web interface Sep 25, 2026
@BryonLewis
BryonLewis self-requested a review September 25, 2026 16:55

@BryonLewis BryonLewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and allows adding multicamera datasets for review on web. Added a small change to prevent sub-cameras from being added as their own dataset.

@BryonLewis
BryonLewis merged commit 5bfd57f into main Sep 25, 2026
3 checks passed
@BryonLewis
BryonLewis deleted the fix/web-stereo-review branch September 25, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants