Tune video encoder for low-delay streaming - #60
Merged
Merged
Conversation
jspanchu
force-pushed
the
tune-encoder
branch
from
September 18, 2026 17:55
cd453ab to
ad8ae0d
Compare
jspanchu
force-pushed
the
tune-encoder
branch
2 times, most recently
from
September 18, 2026 17:57
379fdf3 to
6b8451a
Compare
Collaborator
|
you need to fix some pre-commit issue. Otherwise looks good. |
jspanchu
force-pushed
the
tune-encoder
branch
from
September 18, 2026 18:03
6b8451a to
387e2d8
Compare
jourdain
approved these changes
Sep 18, 2026
Collaborator
|
Check the CI, I'm not sure why there is a type issue on linux |
jspanchu
force-pushed
the
tune-encoder
branch
2 times, most recently
from
September 18, 2026 18:16
856f3e8 to
a86d4b6
Compare
jspanchu
force-pushed
the
tune-encoder
branch
from
September 18, 2026 18:18
a86d4b6 to
04e9bf4
Compare
Member
Author
|
pre-commit and pytest CI is clean. |
Member
Author
|
the type issue was because some test was trying to pass a float target_fps=30.0 to the encoder.time_base_end property which in C++ is an int. i fixed that too by converting to int before passing the value to C++ setter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tunes the video encoder to achieve a target_fps and a target_bitrate (for those that support Constant Bit Rate mode).